-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meetbot: Line length, linting, tweaks, fixes #1578
Conversation
89dd5b2
to
aa7578d
Compare
aa7578d
to
df1d5dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this isn't a "request changes" per se, because I'm perfectly happy with the diff as-is. However, there are some "extra mile" type tweaks that I called out in line notes (most of which are just examples of issues that occur several times each throughout the code). If you're feeling extra "fix-it-y", have at these! 😸
bd4b79b
to
e64b00d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not particulary fan of replacing 'string'
by "string"
. Quite the opposite, actually.
Otherwise, nice work.
e5f2bdc
to
3b85955
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff isn't the easiest to read. I'd have love separated and atomic commits to review it, change by change (lower_case function in one commit, proper import in another one, log refactoring after that, etc.).
But that'll do. I didn't review the feature itself, I assume @half-duplex make it work as before.
This should satisfy most scrutinizer and human complaints, and removes a couple TODOs (display durations in minutes instead of seconds).
3b85955
to
cdb2fe2
Compare
(Switched back to sopel.web to remove #1616 dependency and added a \n after |
Still a great work! Thank you. 👍 |
This should satisfy the easy scrutinizer, flake8, and human complaints, and removes a couple TODOs (display durations in minutes instead of seconds).