Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meetbot: Line length, linting, tweaks, fixes #1578

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

half-duplex
Copy link
Member

This should satisfy the easy scrutinizer, flake8, and human complaints, and removes a couple TODOs (display durations in minutes instead of seconds).

@half-duplex half-duplex force-pushed the meetbot-cleanup branch 2 times, most recently from 89dd5b2 to aa7578d Compare April 30, 2019 19:08
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this isn't a "request changes" per se, because I'm perfectly happy with the diff as-is. However, there are some "extra mile" type tweaks that I called out in line notes (most of which are just examples of issues that occur several times each throughout the code). If you're feeling extra "fix-it-y", have at these! 😸

sopel/modules/meetbot.py Show resolved Hide resolved
sopel/modules/meetbot.py Outdated Show resolved Hide resolved
sopel/modules/meetbot.py Outdated Show resolved Hide resolved
sopel/modules/meetbot.py Outdated Show resolved Hide resolved
sopel/modules/meetbot.py Show resolved Hide resolved
@dgw dgw added the Tweak label Apr 30, 2019
@dgw dgw added this to the 7.0.0 milestone Apr 30, 2019
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not particulary fan of replacing 'string' by "string". Quite the opposite, actually.

Otherwise, nice work.

sopel/modules/meetbot.py Outdated Show resolved Hide resolved
sopel/modules/meetbot.py Show resolved Hide resolved
sopel/modules/meetbot.py Outdated Show resolved Hide resolved
sopel/modules/meetbot.py Outdated Show resolved Hide resolved
sopel/modules/meetbot.py Outdated Show resolved Hide resolved
sopel/modules/meetbot.py Outdated Show resolved Hide resolved
sopel/modules/meetbot.py Outdated Show resolved Hide resolved
sopel/modules/meetbot.py Outdated Show resolved Hide resolved
sopel/modules/meetbot.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff isn't the easiest to read. I'd have love separated and atomic commits to review it, change by change (lower_case function in one commit, proper import in another one, log refactoring after that, etc.).

But that'll do. I didn't review the feature itself, I assume @half-duplex make it work as before.

This should satisfy most scrutinizer and human
complaints, and removes a couple TODOs (display durations in
minutes instead of seconds).
@half-duplex
Copy link
Member Author

half-duplex commented Jun 4, 2019

(Switched back to sopel.web to remove #1616 dependency and added a \n after </html>)
I only realized 2/3 of the way through your comments that the changes were significant and dividable enough it should be multiple, apologies.
I did test it about as comprehensively as I can having not used it before (start meeting, run commands, end meeting, logs look sane).

@Exirel
Copy link
Contributor

Exirel commented Jun 5, 2019

I only realized 2/3 of the way through your comments that the changes were significant and dividable enough it should be multiple, apologies.

Still a great work! Thank you. 👍

@dgw dgw merged commit 6e51ec4 into sopel-irc:master Jun 21, 2019
@half-duplex half-duplex deleted the meetbot-cleanup branch June 21, 2019 16:15
@dgw dgw mentioned this pull request Jul 6, 2019
@half-duplex half-duplex restored the meetbot-cleanup branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants