Unignore even more style checks #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
half-duplex
force-pushed
the
checkstyle-updates
branch
from
1037788 to
2f1baea
Compare
Exirel
requested changes
May 1, 2019
half-duplex
force-pushed
the
checkstyle-updates
branch
from
d9704a7 to
d2847a8
Compare
|
@half-duplex aw, now there are conflict to fix first. :( |
half-duplex
force-pushed
the
checkstyle-updates
branch
4 times, most recently
from
3d2b41c to
6a2a813
Compare
|
Had to make the same changes in some new code after the rebase |
Exirel
reviewed
May 12, 2019
half-duplex
force-pushed
the
checkstyle-updates
branch
3 times, most recently
from
204c623 to
853ce79
Compare
|
Of course merging #1578 caused conflicts with this PR, because why wouldn't it? 😑 @half-duplex, would you fix this one up for me over the weekend? 😸 |
|
Oh, that's a very easy conflict to fix! :) |
Preparing for flake8 3.7
Co-authored-by: Florian Strzelecki <florian.strzelecki@gmail.com>
half-duplex
force-pushed
the
checkstyle-updates
branch
from
853ce79 to
3d6f4cd
Compare
|
Tested merging this to a local branch, and I'm gonna merge it before anything breaks the newly fixed checks. I want better code style just like everyone else! |
|
Me from the future would like to ask himself from the past why he didn't insist on reordering things to prevent a commit with failed tests from being merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unignores (or updates to add) and fixes the following:
E117 over-indented
E127 continuation line over-indented for visual indent
E128 continuation line under-indented for visual indent
F632 use ==/!= to compare str, bytes, and int literals
With the above fixed, flake8 3.7.7 finds no errors, so the 3.6 pin is replaced with 3.7
checkstyle.sh's py3-unsafeunicode()detection seemed to have some inverted logic and was reporting files containingunicode = stras potentially unsafe, instead of only files not containing that.