Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell: use config to send reminders as private messages #1694

Merged
merged 3 commits into from
Nov 14, 2019

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Sep 26, 2019

This fix #1151

  • config.tell.use_private_reminder (y/n) [n]: send tell/ask reminders as private messages
  • config.tell.maximum_public [4]: maximum number of tell/ask reminders to send as public messages before sending them as private messages

As a bonus point: minor refactoring with unit tests.

@Exirel Exirel added this to the 7.0.0 milestone Sep 26, 2019
@Exirel Exirel requested a review from dgw September 26, 2019 15:55
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks 👍 in general, but uh… Why bring io into this? The only thing I see used from that module, io.open(), is just an alias to the built-in open().

@Exirel
Copy link
Contributor Author

Exirel commented Oct 12, 2019

Why bring io into this? The only thing I see used from that module, io.open(), is just an alias to the built-in open().

Because Python 2.7's open function doesn't know about "encoding". Since I wanted to deal with unicode string only, I switched to io.open.

Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough about io. Now I just hope this doesn't cause conflicts with #1699. 😸

@Exirel
Copy link
Contributor Author

Exirel commented Oct 22, 2019

Now I just hope this doesn't cause conflicts with #1699.

I think it'll. But that's okay, the change aren't that big, and you now have unit-tests to help you!

@dgw dgw merged commit a33b024 into sopel-irc:master Nov 14, 2019
@Exirel Exirel deleted the tell-in-private branch January 14, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add private option to .tell
2 participants