remind, tell: Use config name in fake .db files
#1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added a commit
to sopel-irc/sopel.chat
that referenced
this pull request
Oct 6, 2019
dgw
force-pushed
the
tell-remind-db-configname
branch
from
6e93298 to
2fd7c50
Compare
|
Should we use a separate file at all? Now that there is #1621, this information could live in the big database. |
|
@kwaaak It could, but the These plugins could use custom tables, true, but their dump files are not that different from the GeoIP and malwaredomains files we already cache on disk. And those definitely aren't going into |
|
(Wrong browser tab, touched milestones I shouldn't have. Whoops.) |
Exirel
approved these changes
Nov 9, 2019
Instead of using the bot's nick and configured host (to connect to), let's use the config `basename`. This matches the default SQLite DB filename and the names used for Sopel's log files.
dgw
force-pushed
the
tell-remind-db-configname
branch
from
2fd7c50 to
0063471
Compare
dgw
added a commit
to sopel-irc/sopel.chat
that referenced
this pull request
Nov 28, 2019
dgw
added a commit
to sopel-irc/sopel.chat
that referenced
this pull request
Jan 11, 2020
dgw
added a commit
to sopel-irc/sopel.chat
that referenced
this pull request
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the bot's nick and configured host (to connect to), let's use the config
basename. This matches the default SQLite DB filename and (as of #1547) the names used for Sopel's log files.Closes #1359. Labeling "Documentation" as I need to write a new section covering this for the upgrade guide in sopel-irc/sopel.chat#17 (already referenced here in the help links given if the migration fails).