Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calc: extract .py command to its own file #1710

Merged
merged 3 commits into from
Nov 18, 2019
Merged

calc: extract .py command to its own file #1710

merged 3 commits into from
Nov 18, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 14, 2019

This is mostly so it's easier to disable .py (which relies on an external web service and may encourage skiddies) while keeping the basic calculation command available.

@dgw dgw added the Tweak label Oct 14, 2019
@dgw dgw added this to the 7.0.0 milestone Oct 14, 2019
@dgw dgw requested a review from a team October 14, 2019 20:41
@dgw dgw force-pushed the py-cmd-own-file branch from 98c3ab5 to c07bf12 Compare October 14, 2019 20:54
@dgw
Copy link
Member Author

dgw commented Oct 14, 2019

dgw force-pushed the py-cmd-own-file branch from 98c3ab5 to c07bf12 20 seconds ago

*grumbles about text editors making stupid default line-ending choices for new files*

This was referenced Oct 16, 2019
@Exirel
Copy link
Contributor

Exirel commented Nov 9, 2019

@dgw I had a very quick look at the conflict, and I think it has something to do with the quote/unquote thing you refactored few weeks ago. I'm not sure, but I believe you will need to rework a bit that part.

@dgw dgw force-pushed the py-cmd-own-file branch from 7e1c09a to 56d117b Compare November 9, 2019 15:15
@dgw
Copy link
Member Author

dgw commented Nov 9, 2019

Another fairly easy rebase. 😁

The other draft PRs based on this will be "more fun".

Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dgw dgw merged commit 1df2178 into master Nov 18, 2019
@dgw dgw deleted the py-cmd-own-file branch November 18, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants