Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py: configurable endpoint #1712

Merged
merged 1 commit into from
Nov 19, 2019
Merged

py: configurable endpoint #1712

merged 1 commit into from
Nov 19, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 17, 2019

Adds an option to configure the Oblique endpoint Sopel should use for .py commands.

Based on #1710 branch, so will begin its life as a draft.

Note to self: Rescue the good bits from your last time implementing this (before deciding to split .py into its own file). See 0d4fc85, e16ae1f, & abda3a6 from the forgotten calc-config branch.

@dgw dgw added the Feature label Oct 17, 2019
@dgw dgw added this to the 7.0.0 milestone Oct 17, 2019
@dgw dgw requested a review from a team October 17, 2019 20:54
@dgw dgw marked this pull request as ready for review November 18, 2019 19:19
@dgw dgw force-pushed the py-cmd-endpoint-option branch from 626ea6b to 0c41751 Compare November 18, 2019 19:27
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (even if I still hate the .py command)

@dgw
Copy link
Member Author

dgw commented Nov 19, 2019

(even if I still hate the .py command)

You're not alone. 😹 Script kiddies finding ways to corrupt the App Engine instance state are a pain, but we only need to get through 7.x. Then this will become an external package for 8.0, and no more random CI failures because App Engine's state got corrupted!

Edit: And of course merging #1711 caused my changes to conflict with each other. Brilliant!

@dgw dgw force-pushed the py-cmd-endpoint-option branch from 0c41751 to c836d28 Compare November 19, 2019 21:58
@dgw dgw merged commit 24e90d6 into master Nov 19, 2019
@dgw dgw deleted the py-cmd-endpoint-option branch November 19, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants