Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: migrating db tests to sqlalchemy #1777

Merged
merged 1 commit into from
Dec 15, 2019
Merged

tests: migrating db tests to sqlalchemy #1777

merged 1 commit into from
Dec 15, 2019

Conversation

RustyBower
Copy link
Contributor

@RustyBower RustyBower commented Dec 6, 2019 •
edited
Loading

This should fix #1623

@RustyBower RustyBower force-pushed the sqlalchemy_migration branch from 3f920d9 to 608b766 Compare December 6, 2019 08:26
@RustyBower RustyBower force-pushed the sqlalchemy_migration branch from 608b766 to b33dc0d Compare December 6, 2019 17:07
@dgw dgw added this to the 7.0.0 milestone Dec 6, 2019
@dgw dgw requested review from dgw and Exirel December 6, 2019 21:09
dgw
dgw approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dgw dgw mentioned this pull request Dec 10, 2019
Merged
@dgw
Copy link
Member

dgw commented Dec 12, 2019

@Exirel I'd still like you to look at these changes, but I also want to merge this and #1781 together, in the next couple days, since they're kinda related…ish.

@dgw dgw merged commit 4432e47 into sopel-irc:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel left review comments

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Medium Priority Tests
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

test_db.py needs updating
3 participants
@RustyBower @dgw @Exirel