-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test_tools's mocks are obsolete #1781
Conversation
I'm not a huge fan of needing to put Dropping |
Ok, I'll do two thing:
And I think we'll be good to go. As mentioned on IRC, internal plugins will become externals by Sopel 8.0, and we have a year to craft better testing tools. I'll remember that:
|
be852ee
to
08c8079
Compare
@dgw and done! It's way easier to review now I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things. Deprecating the Mock*
classes is a natural thing to do after making the "real" objects testable directly. We can keep the discussion going about how to test say()
vs. reply()
in a backwards-compatible way, if you like. 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash what you're gonna squash, @Exirel.
lol |
bba2935
to
ba9bf84
Compare
Done. |
test: test_tools's mocks are obsolete
This PR makes test_tools's mocks obsolete, adding deprecation warning on
MockConfig
,MockSopel
, andMockSopelWrapper
- replaced by theconfigfactory
fixture, thebotfactory
fixture, and by thesopel.bot.SopelWrapper
class respectively.As far as I'm concerned, Sopel's codebase doesn't use
MockSopel
norMockConfig
, making sure that no part of Sopel assumes~/.sopel/
as the homedir. We may close issue #946 once this is merged.