Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

announce: send announces to TARGMAX channels at once, if advertised #1859

Merged
merged 2 commits into from
Oct 10, 2020
Merged

announce: send announces to TARGMAX channels at once, if advertised #1859

merged 2 commits into from
Oct 10, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented May 9, 2020

Description

Tin. Closes #1306.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches
    • Not against a live server. I started writing unit tests but got lost in @Exirel's mocks. 😅 Maybe he'll have time to help me finish later.

@dgw dgw added the Tweak label May 9, 2020
@dgw dgw added this to the 7.1.0 milestone May 9, 2020
Exirel
Exirel requested changes May 9, 2020
View reviewed changes
sopel/modules/announce.py Outdated Show resolved Hide resolved
sopel/modules/announce.py Outdated Show resolved Hide resolved
@dgw
Copy link
Member Author

dgw commented May 9, 2020

The big issue right now, besides lack of tests, is that py2 can't import from builtins.

@dgw
Copy link
Member Author

dgw commented May 11, 2020

Re the new commit: "Thanks, I hate it." Don't worry, I don't want to merge that kludge.

@dgw dgw force-pushed the announce-batch branch from 3a5e228 to 3ed8b76 Compare May 11, 2020 17:55
@dgw
Copy link
Member Author

dgw commented May 11, 2020

Well-taken point from @Exirel applied: Performance concerns in this case are not significant enough to worry about what underlying implementation of range() we get.

@Exirel
Copy link
Contributor

Exirel commented Sep 12, 2020

@dgw I still like this PR. If you have time to touch it... 👍

@dgw dgw mentioned this pull request Sep 14, 2020
Merged
4 tasks
@dgw
Copy link
Member Author

dgw commented Sep 26, 2020

@Exirel I updated it a bit, but have not rebased yet. Want to know first if it's good enough (obviously not the perfect solution discussed in line notes in that prior review) to ship, while we work on the larger API question.

@Exirel
Copy link
Contributor

Exirel commented Sep 26, 2020

@dgw all good for a rebase & squash.

@dgw
Copy link
Member Author

dgw commented Sep 26, 2020

@Exirel This is now the squishiest PR you ever saw (not really, but I wanted to say that anyway)

@dgw dgw marked this pull request as ready for review September 26, 2020 20:06
@dgw dgw requested a review from Exirel September 26, 2020 20:07
@dgw
announce: send announces to TARGMAX channels at once, if advertised
b7b6b46 
Reduces the bot's network overhead, and might make servers happier.
Exirel
Exirel approved these changes Sep 26, 2020
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Exirel
Exirel requested changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick for argument checking, and we are all good!

@Exirel Exirel mentioned this pull request Oct 2, 2020
Merged
4 tasks
@dgw dgw requested a review from Exirel October 2, 2020 16:50
@dgw dgw merged commit b16cfcd into master Oct 10, 2020
@dgw dgw deleted the announce-batch branch October 10, 2020 06:07
@dgw dgw mentioned this pull request Aug 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Tweak
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

announce: Batch up to MAXTARGETS channels at a time if available
2 participants
@dgw @Exirel