admin, pronouns, py: argument checking, logging, and better reply on error messages #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
Tweak
Bugfix
dgw
requested changes
Oct 18, 2020
dgw
approved these changes
Oct 22, 2020
Co-authored-by: dgw <dgw@technobabbl.es>
Co-authored-by: dgw <dgw@technobabbl.es>
Exirel
force-pushed
the
plugins-argument-checking
branch
from
ed85b02 to
880ca01
Compare
|
Squashed & rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once #1859 and #1950 implement their part, this will fix #1001
I didn't changed all the reply-on-error messages, because most of them are fine. If someone wants to nitpick, they will be able to do some PR (hey, it's hacktoberfest or something). The most important part was to make sure admin checks command args.
Also I added some
Checklist
make qa(runsmake qualityandmake test)