core: fix invalid usage of r-string for SASL auth token #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
High Priority
Bugfix
dgw
requested changes
Oct 31, 2020
dgw
approved these changes
Oct 31, 2020
Also use `\x00` instead of `\0`, which is an invalid escape sequence as of Python 3.8: https://docs.python.org/3.8/library/re.html (no relevant anchor; search for "invalid escape" in page contents). Co-authored-by: dgw <dgw@technobabbl.es>
dgw
force-pushed
the
core-fix-sasl-auth-token
branch
from
1b17ba3 to
fcd8365
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1974
@dgw if this can be merged in priority, as this bug prevent from using SASL in dev (I don't use SASL so I didn't notice).
Checklist
make qa(runsmake qualityandmake test)