Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, test: make SASL PLAIN token generation testable (and test it) #1977

Merged
merged 1 commit into from
Oct 31, 2020
Merged

core, test: make SASL PLAIN token generation testable (and test it) #1977

merged 1 commit into from
Oct 31, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 31, 2020

Description

This is a follow-up to #1974 & #1976, which should prevent a similar regression from being introduced in the future.

Considered putting the new utility function in sopel.tools, but figured it's not useful to anything outside coretasks.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added this to the 7.1.0 milestone Oct 31, 2020
@dgw dgw requested a review from Exirel October 31, 2020 18:17
@dgw dgw merged commit 0dc8d58 into master Oct 31, 2020
@dgw dgw deleted the sasl-token-test branch October 31, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Tests Tweak
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel