Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #39 - ListDetail 뷰 Domain, Data 구현 #45

Merged
merged 7 commits into from
Dec 18, 2022

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • Domain, Data 레이어 구현

📌 참고 사항

  • 아직 network 부분은 연결하지 않았고, 목업데이터로 넣어뒀습니다
    제대로 포스트맨으로두 통신을 못해봐서 더미 유저를 서버에서 받거나 회원가입 부분이 연결된 다음에 구현할 생각입니다

📸 스크린샷

기능 스크린샷
기능이름 스크린샷 첨부

📮 관련 이슈

@yangsubinn yangsubinn added Feat 새로운 기능 구현 양수🌷 labels Dec 13, 2022
@yangsubinn yangsubinn self-assigned this Dec 13, 2022
Copy link
Member

@devxsby devxsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 수빈찌 🤍
저도 얼른 작업해야겠네여 .. ☃️

let deleteSuccess = useCase.deleteSuccess

listDetailModel.asDriver()
.compactMap { $0 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Comment on lines +379 to +380
self.resetData()
self.reloadData(.completed)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조으네여

Copy link
Contributor

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음 주 내로 회원가입 부분 API 연결해서 테스트해 볼 수 있게 할게요!!
수고하셨습니다~!

Merge branch 'develop' of https://github.com/sopt-makers/SOPT-Stamp-iOS into feat/sopt-makers#39-ListDetailDomain
@yangsubinn yangsubinn merged commit cbd239f into sopt-makers:develop Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 size/L 양수🌷
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 미션 상세 뷰 Domain 및 Data 구현
4 participants