Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #47 - Toast파일 Components로 이동 및 커스텀 #48

Merged
merged 2 commits into from
Dec 18, 2022
Merged

[Fix] #47 - Toast파일 Components로 이동 및 커스텀 #48

merged 2 commits into from
Dec 18, 2022

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • showToast -> Toast DSKit Components로 이동

📌 참고 사항

  • Toast 클래스를 DSKit을 사용해서 커스텀해야 하기 때문에 Component에 위치하는 것이 더 맞을 것 같아서 이동시키고 커스텀 했습니다
  • 브랜치를 바로 이어서 작업해서 먼저 올린 풀리퀘 [Feat] #39 - ListDetail 뷰 Domain, Data 구현 #45 의 커밋까지 포함되어 있습니다

📸 스크린샷

기능 스크린샷
토스트 �

📮 관련 이슈

@yangsubinn yangsubinn added Fix 문제 해결, 코드 수정 양수🌷 labels Dec 15, 2022
@yangsubinn yangsubinn self-assigned this Dec 15, 2022
devxsby
devxsby approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@devxsby devxsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오웅 빠르시네여 감사합니닷 !!! 🎄❤️

@yangsubinn yangsubinn mentioned this pull request Dec 17, 2022
Merged
L-j-h-c
L-j-h-c approved these changes Dec 18, 2022
View reviewed changes
Copy link
Contributor

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

lsj8706
lsj8706 approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@pull-request-size pull-request-size bot added size/S and removed size/L labels Dec 18, 2022
@yangsubinn yangsubinn merged commit 83b4bf6 into sopt-makers:develop Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devxsby devxsby devxsby approved these changes

@lsj8706 lsj8706 lsj8706 approved these changes

@L-j-h-c L-j-h-c L-j-h-c approved these changes

Assignees

@yangsubinn yangsubinn

Labels
Fix 문제 해결, 코드 수정 size/S 양수🌷
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 커스텀 토스트 메세지 수정
4 participants
@yangsubinn @L-j-h-c @lsj8706 @devxsby