Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] meta tag 수정 #2

Merged
merged 3 commits into from
Aug 17, 2024
Merged

[Fix] meta tag 수정 #2

merged 3 commits into from
Aug 17, 2024

Conversation

lydiacho
Copy link
Member

🧑‍🎤 Summary

  • conflict fix 과정에서 발생한 build error 해결
  • meta tag를 SOPT 버전으로 수정
  • ogtag link를 경로 -> full url로 수정

@lydiacho lydiacho self-assigned this Aug 17, 2024
@height Height
Copy link

height bot commented Aug 17, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@lydiacho lydiacho changed the title Fix/meta tag [Fix] meta tag 수정 Aug 17, 2024
eonseok-jeon
eonseok-jeon approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@eonseok-jeon eonseok-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요~~

index.html
Comment on lines +23 to +25
<link rel="icon" href="https://recruit.sopt.org/favicon.ico" sizes="32x32" />
<link rel="icon" href="https://recruit.sopt.org/icon.svg" type="image/svg+xml" />
<link rel="apple-touch-icon" href="https://recruit.sopt.org/apple-touch-icon.png" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그냥 /favicon.ico로만 해도 잘 되는데 앞에 url을 추가해준 이유가 있으신가요?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아ㅏㅏㅏㅏㅏ 다른 repo pr에서 내용 확인했습니다!!

@lydiacho lydiacho merged commit 144c586 into release/sopt Aug 17, 2024
1 check passed
@lydiacho lydiacho deleted the fix/meta-tag branch August 20, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eonseok-jeon eonseok-jeon eonseok-jeon approved these changes

Assignees

@lydiacho lydiacho

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lydiacho @eonseok-jeon