Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] meta tag 수정 #2

Merged
merged 3 commits into from
Aug 17, 2024
Merged

[Fix] meta tag 수정 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fcb05f
fix: build 에러 해결
lydiacho Aug 17, 2024
b69866d
fix: index.html 수정
lydiacho Aug 17, 2024
3cbe2fd
fix: ogtag link full url로 수정
lydiacho Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,32 +18,32 @@
<meta property="og:type" content="website" />
<meta property="og:locale" content="ko_KR" />

<link rel="manifest" href="/makersManifest.webmanifest" />
<link rel="manifest" href="https://recruit.sopt.org/manifest.webmanifest" />

<link rel="icon" href="/makersFavicon.ico" sizes="32x32" />
<link rel="icon" href="/makersIcon.svg" type="image/svg+xml" />
<link rel="apple-touch-icon" href="/makers-touch-icon.png" />
<link rel="icon" href="https://recruit.sopt.org/favicon.ico" sizes="32x32" />
<link rel="icon" href="https://recruit.sopt.org/icon.svg" type="image/svg+xml" />
<link rel="apple-touch-icon" href="https://recruit.sopt.org/apple-touch-icon.png" />
Comment on lines +23 to +25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그냥 /favicon.ico로만 해도 잘 되는데 앞에 url을 추가해준 이유가 있으신가요?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아ㅏㅏㅏㅏㅏ 다른 repo pr에서 내용 확인했습니다!!


<meta property="og:title" content="SOPT makers 모집 지원하기" />
<meta property="og:description" content="SOPT makers의 신입 기수 모집페이지입니다." />
<meta property="og:site_name" content="SOPT makers 리크루팅" />
<meta property="og:url" content="https://recruiting.sopt.org" />
<meta property="og:title" content="SOPT 모집 지원하기" />
<meta property="og:description" content="SOPT의 신입 기수 모집페이지입니다." />
<meta property="og:site_name" content="SOPT 리크루팅" />
<meta property="og:url" content="https://recruit.sopt.org" />

<meta property="og:image" content="/makersOg.png" />
<meta property="og:image:alt" content="SOPT makers 리크루팅" />
<meta property="og:image" content="https://recruit.sopt.org/imgOg.png" />
<meta property="og:image:alt" content="SOPT 리크루팅" />
<meta property="og:image:width" content="800" />
<meta property="og:image:height" content="400" />

<meta property="twitter:card" content="website" />
<meta name="twitter:title" content="SOPT makers 모집 지원하기" />
<meta name="twitter:description" content="SOPT makers의 신입 기수 모집페이지입니다." />
<meta name="twitter:image" content="/makersOg.png" />
<meta property="twitter:image:alt" content="SOPT makers 리크루팅" />
<meta property="twitter:site" content="https://recruiting.sopt.org" />
<meta name="twitter:title" content="SOPT 모집 지원하기" />
<meta name="twitter:description" content="SOPT의 신입 기수 모집페이지입니다." />
<meta name="twitter:image" content="https://recruit.sopt.org/imgOg.png" />
<meta property="twitter:image:alt" content="SOPT 리크루팅" />
<meta property="twitter:site" content="https://recruit.sopt.org" />

<title>SOPT makers 모집 지원하기</title>
<title>SOPT 모집 지원하기</title>
<meta name="author" content="sopt makers team official 4th" />
<meta name="description" content="SOPT makers의 신입 기수 모집페이지입니다." />
<meta name="description" content="SOPT의 신입 기수 모집페이지입니다." />
</head>
<body>
<div id="modal"></div>
Expand Down
4 changes: 2 additions & 2 deletions manifest.webmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"icons": [
{
"src": "/makers_192.png",
"src": "/icon-192.png",
"type": "image/png",
"sizes": "192x192"
},
{
"src": "/makers_512.png",
"src": "/icon-512.png",
"type": "image/png",
"sizes": "512x512"
}
Expand Down
1 change: 0 additions & 1 deletion src/common/components/Layout/components/Header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const Header = () => {
const { deviceType } = useContext(DeviceTypeContext);
const [isMenuOpen, setIsMenuOpen] = useState(false);

const deviceType = useDevice();
const navigate = useNavigate();
const { pathname } = useLocation();

Expand Down