cluster: make DefaultSyncTimeout infinite. #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2020
Merged
johannesboon
added a commit
to johannesboon/stolon
that referenced
this pull request
Jan 21, 2020
SyncTimeout is currently undocumented and is set to 30 minutes causing unexpected behaviors to users. So make its default set to 0 (infinite). Another PR will document it.
sgotti
force-pushed
the
sync_timeout_disabled_by_default
branch
from
d6617c9 to
709a3d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyncTimeout is currently undocumented and is set to 30 minutes causing
unexpected behaviors to users.
So make its default set to 0 (infinite).
Another PR will document it.