Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip the mag supplement tests when no mags in supplement #51

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Skip the mag supplement tests when no mags in supplement #51

merged 1 commit into from
Nov 13, 2020

Conversation

jeanconn
Copy link
Contributor

Description

Skip the mag supplement tests when no mags in supplement.

This is somewhat in the style of the other skips in test_agasc_2.

Testing

  • Passes unit tests on linux with old supplement (skipping) . a test with the dev supplement is still failing (not in this change)
  • Functional testing

Fixes #

@jeanconn jeanconn requested a review from taldcroft November 13, 2020 00:10
taldcroft
taldcroft approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I'd say to also turn the warning in loading the supplement into a pass for now. Which is to say until the supplement is being used operationally. Thanks @jeanconn !

@jeanconn jeanconn merged commit 36080b0 into master Nov 13, 2020
@jeanconn jeanconn deleted the skip_tests_with_old_supp branch November 13, 2020 00:27
@javierggt javierggt mentioned this pull request Nov 17, 2020
Merged
@javierggt javierggt mentioned this pull request Dec 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft