Migrate transforms here and make them work for N-d inputs #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the transforms RA,Dec <=> ECI here and makes all the transforms (RA, Dec <=> ECI and RA, Dec <=> yag, zag) work for N-d inputs, where the added dimensions are always at the front (i.e. you would have a 25x3 or 5x5x3 input of ECI's).
It also moves the
norm
function from Ska.quatutil to here and makes it work for multidimensional inputs. There is no explicit new unit test but it is well-covered in the other unit tests.With this and sot/Quaternion#32 then Ska.quatutil is entirely replaced and can be deprecated.
Testing
Fixes #102
Fixes sot/ska_quatutil#13