Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate transforms here and make them work for N-d inputs #104

Merged
merged 8 commits into from
Sep 24, 2020

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Sep 15, 2020

Description

This moves the transforms RA,Dec <=> ECI here and makes all the transforms (RA, Dec <=> ECI and RA, Dec <=> yag, zag) work for N-d inputs, where the added dimensions are always at the front (i.e. you would have a 25x3 or 5x5x3 input of ECI's).

It also moves the norm function from Ska.quatutil to here and makes it work for multidimensional inputs. There is no explicit new unit test but it is well-covered in the other unit tests.

With this and sot/Quaternion#32 then Ska.quatutil is entirely replaced and can be deprecated.

Testing

  • Passes unit tests on MacOS
  • Functional testing (new unit tests)

Fixes #102
Fixes sot/ska_quatutil#13

@taldcroft taldcroft changed the title WIP: migrate more transforms here and make them work for N-d inputs Migrate transforms here and make them work for N-d inputs Sep 23, 2020
@taldcroft
Copy link
Member Author

@jeanconn @javierggt - please have a look at this in the next few days. I'm desperate to actually complete something technical.

chandra_aca/transform.py Outdated Show resolved Hide resolved
@taldcroft taldcroft merged commit 714549d into master Sep 24, 2020
@taldcroft taldcroft deleted the transforms branch September 24, 2020 10:05
@javierggt javierggt mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broadcasting in Ska.quatutil.yagzag2radec Broadcasting in yagzag_to_radec
2 participants