-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding model specifications for BEP and FEP models #62
Conversation
One thing I wonder is if we should revisit the current strategy of bundling the model spec with every checker tool instead of using |
I'd like to pick this back up a year later--since the next version of |
My other recollection was that we hadn't decided if models that weren't in flight use could live in the flight version chandra_models. |
@jeanconn the check tools for the BEP and FEP models are installed in ska flight, FWIW. |
I am ok with having non-flight approved models in a flight approved release. We have precedence for this as well. I keep a non-flight approved version of the IPS Fuel Tank model alongside the flight approved version (the non-flight approved version includes the impact of SSR-B, which I took out to generate the current flight approved version). My perspective is that it is the models that ensure the thermal guidelines are adequately enforced that dictate whether or not a release is "approved". The release tag and commit hash act as a guarantee that each of these models is the correct version. Since each model file spec is separate and does not impact the performance of other models, there is no reason additional models cannot be included. |
I've added limits according to the prescription from PR #75, fixed some naming issues in the files, removed the |
@taldcroft what do you think about this? |
@jzuhone - putting these models in is fine by me. I guess it would be good to see some minimal statement in the description of internal technical review by the ACIS team for the models:
|
Hi @taldcroft--I added text to the description in line with your suggestions. |
This PR adds the model specifications for these BEP and FEP models which ACIS Ops runs during load reviews, but are not yet used for flight approval. These correspond to the FEP1 Actel, FEP1 Mongoose, and BEP PCB temperatures in the ACIS DPA. The check tools for these models will eventually be installed in ska3-flight, see sot/skare3#323 and sot/skare3#325.
I also added a .gitignore to ignore files which appear when this is installed as a Python package.
These models are run at every load review by the ACIS ops team and we examine the validation plots at our weekly tagup. They are not used in the actual review itself, but to monitor the predictions for these temperatures and the agreement of the models with the data. These models are definitely WIP in that some features are not modeled well currently (such as low excursions of the FEP temperatures).
The yellow/caution limits are taken from here:
https://cxc.cfa.harvard.edu/acis/PMON/pmon_limits.txt
and we assume a 2 degree backoff for the "planning" limit in each case, consistent with model accuracy.