Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fep1_actel_check, fep1_mong_check, bep_pcb_check to skare3 #323

Closed
wants to merge 1 commit into from

Conversation

jzuhone
Copy link
Collaborator

@jzuhone jzuhone commented Apr 10, 2020

This PR adds the following packages to skare3:

http://github.com/acisops/fep1_actel_check
http://github.com/acisops/fep1_mong_check
http://github.com/acisops/fep1_actel_check

which are getting upgrades in conjunction with acis_thermal_check v3.0.

I would like to have them in ska3-flight, but we can decide when that should happen.

@@ -0,0 +1,2 @@
export SKA=/proj/sot/ska
pip install --no-deps --verbose --no-binary :all: --no-index .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're pushing to update the installs to use

python setup.py install --single-version-externally-managed --record=record.txt

Will probably move those into the meta.yaml at some point too, but at this point it would probably be good just to get the python setup.py transition. Probably also don't need to define SKA.

- six
- numpy
- matplotlib
- acis_thermal_check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think everything now needs setuptools_scm in build. Right @javierggt ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, it looks like these new packages aren't set for setuptools_scm / ska_helpers so that previous comment may be moot for now?

@jzuhone
Copy link
Collaborator Author

jzuhone commented Apr 13, 2020

@jeanconn I copied the meta.yaml and build.sh files for these from the dpa_check one, so if we need to fix these then we need to fix the other ACIS package configurations. Is that what we should do here too?

@jeanconn
Copy link
Contributor

Superseded by #340

@jeanconn jeanconn closed this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants