Change so date like 2020:001 is midnight not noon #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
FYI this will be tagged as version 4.0, giving a major version bump for the back-incompatible change. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on popular demand, this changes Chandra.Time so that a date like
2020:001will be taken as2020:001:00:00:00not2020:001:12:00:00.This adds a new function
use_noon_day_startto provide back-compatibility where necessary. Cheta back-end data ingest is one intended use case.This is likely to break at least a few things, so testing will be critical.
This is targeted for shiny: both the skare3 branch and local branch here called
shiny.Testing
Closes #5
(from 2012!)