Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster guessing of CxoTime-specific formats #13

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Conversation

taldcroft
Copy link
Member

Description

When guessing greta, secs, or date format inputs, this requires that the inputs have the right type (string, number, string, respectively). This shaves off some time that would be spent uselessly guessing, and also fixes a collision for times in secs that look like a valid greta time. [GRETA times do currently accept a float/int input, following the behavior of MATLAB tools].

Testing

  • Passes unit tests on MacOS (note: tests cover the case of supplying each of the guessed formats without providing the format arg.

@taldcroft taldcroft merged commit 2795b06 into master Sep 25, 2020
@taldcroft taldcroft deleted the faster-guess branch September 25, 2020 11:52
@javierggt javierggt mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant