-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Much faster parsing in CxoTime and add maude format #15
Conversation
Cool! Though the status of the astropy code isn't clear to me. Are you sideways-porting to get this in faster here because it will take longer in astropy? Or because the two types need more special code for handling here? I'm just trying to keep an eye on the things that we might want to pull back out of cxotime as you make advances in astropy.time . |
The astropy 4.2 release may well get dragged out beyond the New Year, and I'd like to get these speed enhancements into CxoTime for shiny. These changes override the base methods in astropy.time so I don't expect any problems, but for sure we'll want to mostly revert this PR when we get 4.2 into Ska3. This PR has been structured with the mixin class to make that process pretty straightforward when we do it. |
903adeb
to
7e0b262
Compare
Thanks for adding the maude format. It will be helpful in the future when many others are using it in there daily tasks. I wanted to move my comments from the Slack conversations to here. The maude is returned as a numerical value from the server itself, so it looks like all timestamps will need to be converted before ingested into cxotime. Also, as mentioned, the timestamps will always come back with the exact same amount of digits, which is 16 (2^4). |
Thank you for the explanation, Tom. It seems that strings and numbers are acceptable for the maude format, as long as format='maude' is used. |
This reverts commit b66d37a.
12dbe42
to
f464180
Compare
Description
This effectively does a backport (or sideways port) of astropy/astropy#10360 to speed up parsing of
date
andgreta
format strings by a factor of about 20 and 50, respectively.For large arrays, the CxoTime object creation time on my Mac is around 300 ns per time.
This also adds a new
maude
format that is basicallygreta
as an int64 without the.
. It was easiest/fastest to toss this into the parsing PR.Some timings:
Testing