Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve get_cmds_from_backstop #162

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Improve get_cmds_from_backstop #162

merged 1 commit into from
Mar 28, 2020

Conversation

taldcroft
Copy link
Member

Description

Don't entirely throw away starcat cmds when remove_starcat=True, just toss the parameters.

Testing

  • Passes unit tests on MacOS
  • Functional testing (updated unit tests)

@taldcroft
Improve get_cmds_from_backstop
297d213 
Don't entirely throw away starcat cmds, just
toss the parameters, when `remove_starcat=True`.
@taldcroft taldcroft merged commit ebf6787 into master Mar 28, 2020
@taldcroft taldcroft deleted the starcats branch March 28, 2020 21:20
@javierggt javierggt mentioned this pull request May 26, 2020
Merged
@javierggt javierggt mentioned this pull request Nov 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taldcroft