SHINY: add times to states and commands outputs #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
changed the title
taldcroft
changed the title
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds times (in CXC seconds) to states and commands. In looking at real use cases these columns are typically needed and the impact of adding them by default is not so bad.
It also converts columns in the
CommandsTablefrom bytes to unicode. I found thatChandra.Time.date2secsfailed for bytes input. This could be fixed, but that failure points to other subtle problems that can be encountered using bytestring values (even though astropy Table does a reasonable job of hiding that with the unicode sandwich).Testing