Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_get_l0_images ends up trying to load mica/archive/asp1/archfiles… #224

Merged
merged 1 commit into from
Jun 30, 2020
Merged

test_get_l0_images ends up trying to load mica/archive/asp1/archfiles… #224

merged 1 commit into from
Jun 30, 2020

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Jun 23, 2020 •
edited by taldcroft
Loading

Description

When I run locally, test_get_l0_images ends up trying to load mica/archive/asp1/archfiles.db3, so the test fails. Shouldn't it be skipped?

Also, I just copied the same check that is made in test_asp_l1, but this test fails if there are broken links.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • [N/A] Functional testing

jeanconn
jeanconn approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@jeanconn jeanconn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. (And you can check "passes unit tests" if it works according to plan even if it "skips appropriately" instead of "passes")

@taldcroft taldcroft merged commit 01e44de into master Jun 30, 2020
@taldcroft taldcroft deleted the asp-l1-test-skip branch June 30, 2020 20:00
@javierggt javierggt mentioned this pull request Nov 17, 2020
Merged
@javierggt javierggt mentioned this pull request Dec 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javierggt @jeanconn @taldcroft