Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning when account doesn't have axafvv access #242

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

taldcroft
Copy link
Member

Description

Small change in one test so that automated Ska3 regression testing can pass running as jgonzale.

Testing

  • Passes unit tests on MacOS
  • [N/A] Functional testing

@jeanconn
Copy link
Contributor

I am of the opinion that the account warning should be ignored on the ska_testr side.

@jeanconn
Copy link
Contributor

Well, and jgonzale should get the access.

@taldcroft
Copy link
Member Author

I am of the opinion that the account warning should be ignored on the ska_testr side.

It is actually not that easy to ignore warnings like this in ska_testr. Instead you need to change testr : https://github.com/sot/testr/blob/master/testr/runner.py#L12. The problem is that pytest emits the whole warning section in addition to the particular line.

Once you tell testr to ignore it then python setup.py test will ignore it, and then there is not really much point in emitting the warning to begin with.

I guess if it is not acceptable to routinely skip this test (if run without credentials) then we need to ensure that @javierggt has credentials.

@taldcroft
Copy link
Member Author

Thinking more, this test relates to a single-user (@jeanconn) function used only in automated processing. If it ever fails then we'll get warnings / errors in the logs. I mostly just want to get ska_testr clean at this point.

@taldcroft taldcroft requested a review from jeanconn October 5, 2020 13:56
@taldcroft taldcroft merged commit 8c8b762 into master Oct 5, 2020
@javierggt javierggt mentioned this pull request Dec 7, 2020
@jeanconn jeanconn deleted the no-warn-on-no-vv-access branch December 18, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants