Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed outdated documentation section #245

Merged
merged 1 commit into from
Sep 29, 2020
Merged

removed outdated documentation section #245

merged 1 commit into from
Sep 29, 2020

Conversation

javierggt
Copy link
Contributor

Description

Strictly speaking, this should be replaced by a new section with the right information. I just don't know what that is and want to get rid of the warnings.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

Fixes #

@javierggt javierggt changed the title removed outdated section removed outdated documentation section Sep 29, 2020
@taldcroft taldcroft requested a review from jeanconn September 29, 2020 20:11
jeanconn
jeanconn approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. If we want to add some breadcrumbs about acdc promotion we could but I don't see a fire under that.

@javierggt javierggt merged commit f886bad into master Sep 29, 2020
@javierggt javierggt mentioned this pull request Nov 17, 2020
Merged
@javierggt javierggt mentioned this pull request Dec 7, 2020
Merged
@jeanconn jeanconn deleted the doc-fixes branch December 14, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javierggt @jeanconn