Add img_size guide parameter to control guide star image readout size #344
Conversation
- Parameter name img_size_guide for API consistency - Make img_size an attribute only for GuideCatalog - Validate img_size value - Faster test
|
@jeanconn - I had a number of suggestions and in the end it was easier to just do them in code. I think this is ready so now you should review. |
|
@jskrist - just want to confirm for MATLAB API that you have the machinery to include this optional parameter as necessary. We are imagining (like the include/exclude interface) that there will be a text option box to manually set the guide star image readout size. It would normally be blank in which case ORviewer does not pass that parameter into the |
taldcroft
changed the title
| if value not in (6, 8, None): | ||
| raise ValueError('img_size must be 6, 8, or None') | ||
| if value not in (4, 6, 8, None): | ||
| raise ValueError('img_size must be 4, 6, 8, or None') |
There was a problem hiding this comment.
Looks good. I was thinking this would get checked on the sparkles side but fine to do it here.
There was a problem hiding this comment.
These changes look good to me. I like the idea of moving the parameter to be an attribute only on the guide catalog. Seems fine to add 4x4. And thanks for cleaning up the test by adding an empty dark map and token catalog to speed it up. I note I can't approve my own PR or apparently change owner, so this is just a comment.
|
I note I just asked the question in sot/sparkles#147 .. should we set the OR default size somewhere in the proseco config? |
taldcroft
force-pushed
the
specify_sz
branch
from
2d6acd7 to
6ee2f52
Compare
This is now coded in the |
Description
Add img_size parameter to control box size
Testing
Fixes #337
Requires: