Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the check on repo tip being at the latest tag #38

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Jul 11, 2023

Description

Since we maintain the flight chandra_models repo carefully and have processes in place to ensure its integrity, this PR removes the check that the current tip is at the latest tag. This seems to cause more problems than it solves.

Interface impacts

Testing

Unit tests

  • Mac

Independent check of unit tests by Jean

  • Mac

Functional tests

I checked out chandra_models at 3.48 and ran tests from master and no-repo-tip-check to confirm that the tests no longer FAIL on the tip mismatch.

========================================================== short test summary info ===========================================================
FAILED ska_helpers/tests/test_chandra_models.py::test_get_data_extra_kwargs - ValueError: repo tip is not at tag 3.49
FAILED ska_helpers/tests/test_chandra_models.py::test_get_repo_version - ValueError: repo tip is not at tag 3.49
================================================== 2 failed, 38 passed, 3 skipped in 6.44s ===================================================
(ska3-matlab-2023.4rc6) spark:ska_helpers jean$ git checkout no-repo-tip-check
Switched to branch 'no-repo-tip-check'
Your branch is up to date with 'origin/no-repo-tip-check'.
(ska3-matlab-2023.4rc6) spark:ska_helpers jean$ pytest
============================================================ test session starts =============================================================
platform darwin -- Python 3.10.8, pytest-7.2.1, pluggy-1.0.0
rootdir: /Users/jean/git/ska_helpers
plugins: timeout-2.1.0, anyio-3.6.2
collected 43 items                                                                                                                           

ska_helpers/retry/tests/test_retry.py ..........                                                                                       [ 23%]
ska_helpers/tests/test_chandra_models.py .........s....s..                                                                             [ 62%]
ska_helpers/tests/test_git_helpers.py s                                                                                                [ 65%]
ska_helpers/tests/test_paths.py ......                                                                                                 [ 79%]
ska_helpers/tests/test_run_info.py ..                                                                                                  [ 83%]
ska_helpers/tests/test_utils.py .......                                                                                                [100%]

======================================================= 40 passed, 3 skipped in 6.18s ========================================================

@taldcroft taldcroft requested a review from jeanconn July 11, 2023 14:14
@taldcroft taldcroft merged commit cf7aec3 into master Jul 11, 2023
@taldcroft taldcroft deleted the no-repo-tip-check branch July 11, 2023 15:10
@javierggt javierggt mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants