Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getpass.getuser() instead of USER env var #22

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Use getpass.getuser() instead of USER env var #22

merged 1 commit into from
Oct 5, 2020

Conversation

taldcroft
Copy link
Member

Description

On Mac the USER environment variable is not defined normally. The multiplatform way to get the user is with getpass.getuser().

Testing

  • [N/A] Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

Ran on my Mac and it worked.

@taldcroft taldcroft requested a review from jeanconn October 2, 2020 21:49
jeanconn
jeanconn approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taldcroft taldcroft merged commit ddb0626 into master Oct 5, 2020
@taldcroft taldcroft deleted the get-user branch October 5, 2020 13:49
@javierggt javierggt mentioned this pull request Nov 17, 2020
Merged
@javierggt javierggt mentioned this pull request Dec 7, 2020
Merged
@javierggt javierggt mentioned this pull request Mar 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @jeanconn