Remind about ska3-perl in PR template and Issue template #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
commented
Aug 5, 2024
|
I agree that forgetting ska3-perl is one of the most common mistakes, which you see only at the very end of testing, when starcheck tests fail. Having said that, we have about 10 releases per year, and only one or two of those include ska3-perl. This year we have had more, because of osx-arm64. |
|
And in my case, since I did install testing on GRETA and HEAD, starcheck did not fail - it just ran on an older-but-working version of ska3-perl. |
|
I think I've addressed your comments @javierggt . |
javierggt
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remind about ska3-perl in PR template and Issue template .