Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remind about ska3-perl in PR template and Issue template #1384

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Remind about ska3-perl in PR template and Issue template #1384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33e658d
Remind about ska3-perl in PR template and Issue template
jeanconn Aug 5, 2024
924b111
Remove some extra newlines
jeanconn Aug 5, 2024
23dae82
Make ska3-perl conditional in PR template
jeanconn Aug 7, 2024
44f5fb2
Add a colon
jeanconn Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/ISSUE_TEMPLATE/release_flight.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ assignees: ''
- [ ] Promote packages to `flight` conda channel (`skare3-promote ...`).
- [ ] Announce to aca@cfa/slack.
- [ ] Update ska3/flight on HEAD as aca user.
- [ ] Confirm installed versions of ska3-flight and ska3-perl on HEAD with `conda list`
- [ ] Update ska3/flight on GRETA as SOT user.
- [ ] Confirm installed versions of ska3-flight and ska3-perl on GRETA with `conda list`
- [ ] Promote any data products listed in PR to be promoted.
- [ ] Run ska_testr on HEAD and GRETA.
- [ ] Document test results (`skare3-test-dashboard ...`).
Expand Down
11 changes: 10 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE/ska3-flight.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# ska3-flight {version}

This PR includes:
-
-

## Interface Impacts:

Expand All @@ -19,6 +19,15 @@ conda create -n ska3-flight-{version}rc# --override-channels \
ska3-flight=={version}rc#
```

If this release includes an update to ska3-perl, the install process for Aspect will include that. Note: ska3-perl is generally not needed for non-Aspect users.

```
conda create -n ska3-flight-{version}rc# --override-channels \
-c https://icxc.cfa.harvard.edu/aspect/ska3-conda/flight \
-c https://icxc.cfa.harvard.edu/aspect/ska3-conda/test \
ska3-flight=={version}rc# ska3-perl=={version}rc#
```

## Review

All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.
Expand Down