Brackets [] wrongly displayed in Intellij when focused (bold) #129
Comments
|
FWIW i do not see this issue, lntellij 14.1.5 - hack v15
|
|
Any idea how to debug it? PhpStorm, PS 141.x |
|
check #45 maybe, i had some caching issues when i upgraded the font from the previous version that had this behaviour. |
|
Try issue report #100 where a similar problem was identified. They reported an issue on the JetBrains issue tracker. It sounds like this was fixed as of the v2.015 release. |
Important note: previously mentioned bugs seem to be caused by current line highlighting, which overlay-ed the bottom parts of letters on the previous line. My issue seems to be buggy in every case when the bracket is bolded. |
|
But as mentioned in the other bugs, changing font-size to bigger don't help, however, 11 works ok. |
|
PhpStorm 10. v18, bug is still present. |
|
Thank you |
|
just reporting in that this is still present in 2.020 release, i have created a new ticket on the intellj side https://youtrack.jetbrains.com/issue/IDEA-155229 |
|
@jorgheymans mind trying the 25% line spacing script (see top of readme) to see if it addresses this in IntelliJ? |
|
i'm on windows only here sorry , @hrach maybe ? |
|
happy to build them for you if that is the problem. |
|
sure i can try out whatever zip you make available no problem. |
|
Give these a try. This slightly increases the default line spacing across all variants. Do you know how to clear the Windows font cache and confirm that there are not duplicated font files with font upgrades? |
|
well i remove them from the font dir first, then drop the new fonts in the windows font dir is that sufficient? also restarting intellij ofcourse. In any case it did not solve the issue it seems. |
|
I did the same as @jorgheymans with the same result. (Windows 10) |
|
Not IntelliJ IDEA specific, NetBeans has the same problem with bold Hack font:
Also note incorrect glyphs for bold italic: https://bugs.openjdk.java.net/browse/JDK-8078382. |
@CrazyCoder This is sounding like a caching / font duplication issue. We saw this when Windows users' systems did not clear the previously installed versions (this is the default unfortunately). Are you willing to try our new Windows installer to see if it addresses this? cc: @texhex |
|
@CrazyCoder It looks like there may be clipping of the parentheses glyphs in those images as well. Is that the case? |
|
Hmm, this was the first time I installed Hack font on this system, however I tried the installer and it has fixed the problem. Weird.
|
|
@CrazyCoder Windows makes our head ache :) The current Windows installer contains v2.019. v2.020 should be available sometime in the next few days. I would recommend the 2.020 update to Win users. We addressed the hints in some important glyphs (including the zero) that should make a difference on the platform. |
|
@hrach @jorgheymans want to give the installer a try? it looks like it fixed the bracket problem for @CrazyCoder |
|
@CrazyCoder can you let me know how you performed the initial install? |
|
@hrach @jorgheymans @CrazyCoder The Hack Windows installer has been updated to install Hack v2.020. Please give it a try. CC: @chrissimpkins |
Sorry, but I don't understand what should be scripted? If there is this special character issue? |
Right click on .TTF files, Install. |
|
@texhex Wondering if there is a way to provide the functionality of the install tool without the need to compile the installer for those who help test specific issues in the fonts. This wouldn't be used for distribution, but to provide assurance that the problems that we identified (and are addressed with the installer) are not responsible for the issue persistence when testers attempt fixes through new installs. |
|
Wow, thanks! This is very useful and much appreciated. And it will be very useful to easily detect rending issues, just as you proposed. Under which license do you plan to release this source? Would MIT be OK for you? I'm asking because I think it would make sense to push this code to a repository so it is not "lost" in this issue comment. @chrissimpkins Please have a look at the picture, does it help to identify any hinting issues? Also, please let me know if you agree with moving the code to a separate repository. |
|
@texhex it's just an adapted version of the test class that was used in the openjdk ticket, you can use it or modify it as you want. I would be happy to improve it still if needed. Good point about moving it outside of the ticket somewhere, probably could be made more visible. Now, what I noticed just now looking at the picture is that the brackets are only cut off in the LCD HRGB and LCD HGBR aliasing mode, other modes just work fine. Something to do with subpixel rendering perhaps. The rendering hints are described here https://docs.oracle.com/javase/7/docs/api/java/awt/RenderingHints.html in case it helps.. |
|
Yes, LCD HRGB and LCD HGBR screw up the lower part of VALUE_TEXT_ANTIALIAS_GASP and "Antialiased Text Mode" seem to be fine always. Could you please explain what is this T2K scaler is about? When I understood it correctly (Source#1 Source#2), the JDK now uses the Freetype font scaler which seems to have problems with some fonts on Windows when using native scaling, while the T2K scaler is the older font scaler using by the Sun JDK which doesn't had this issue? |
Awesome! Let's see what the godfather of Hack says to all of this. |
|
I'm gonna make them an offer they can't refuse... |
I have the slight feeling I will regret calling you godfather of Hack... |
Ha! Re: How to address this in documentation @texhex @jorgheymans I read the Java issue report last evening and it appears that they closed this as fixed in the patched JDK if I understood it correctly. Do you happen to know if it is possible to define a different JDK in the JetBrains editors? If so, perhaps we provide users with this workaround in the docs. Would either of you be interested in submitting a PR to update our README with the information that Win + JetBrains users need based upon your thoughts? Re: the new Java tool @jorgheymans Jorg, would you be willing to push this tool (or some variant of it that @texhex and you feel will best help to address our Java woes) to a repository and license it so that we can either point users to the tool in order to troubleshoot similar problems or perform this testing ourselves? Further Info Perhaps we could dig in to the Java documentation on these glyph rendering classes too. The |
|
@jorgheymans and thank you for this fantastic Java tool by the way! Much appreciated! I am learning about Java font rendering from your code. |
|
Addendum to #129 (comment): Is it possible, and would it be worthwhile, to add a header in this reporting tool that displays what default antialiasing settings the user's system is using or is this uniform across Windows releases? |
|
@texhex your understanding about the T2K scaler seems correct. @chrissimpkins you can choose whatever license you want for that class. Should it not stay within the hack repository somewhere ? Otherwise just let me know where to push it to. About the default antialiasing settings: if there are no rendering hints specified for the text antialiasing then it falls back to the setting specified for all antialiasing, the setting for this is implementation dependent . It would take a decent amount of digging in the jdk sources to figure out what these settings are, i do not think they are meant to be exposed on the jdk level. Windows and the jdk are two different things, there is no such thing as default settings on the jdk level because every java program is expected to set these settings as they see fit, at least that is my understanding. In terms of switching jdk, this is doable for the masses as long as its a released version. The jdk used for starting intellij does not have to be the one used for compiling the project . We could add all this in the README. I will have a look to send a PR the next few days to explain all this in the README somewhere. |
I see. Thanks
This is a potential solution then, albeit a very onerous one to address your typeface display...
That would be great if you are willing to do it. If not, please simply let me know what you feel users need to know to work around this issue. Our README is very long, so the more concise the better, particularly since this only applies to a subset of users.
I would prefer to expose this in its own repository so that we avoid cluttering the issue report threads here with tool issues. I would be happy to host it in our Source Foundry organization which is where we keep our other project tools, or feel free to push to your own personal account and we would be happy to send people your way when this tool is needed. Also, can you confirm that this block: if (args.length == 1) {
DEFAULT_TEST_STRING = args[0];
}modifies the default constant string defined at the top of the file with the first argument to the executable? This would definitely be a desired feature so that we can test other glyphs that prove problematic. We could even consider making this available as a general tool for typeface developers and provide a way for them to specify the typeface to be tested on the CL. Some thoughts. We can start here for now. Let me know how you would like to approach the repository. Thanks again for all of your efforts. Will acknowledge these contributions on our contributors list. |
|
ok for me to host that class somewhere in the source foundry repo. Indeed, the test class allows for a string to be passed on the command line :
will render the canvas using "[#] __ [#]" (without the quotes). i was thinking as an improvement it would also read text from a file, for those characters that are difficult to pass on the command line. Also capturing the canvas automatically into a jpg would allow for easy regression testing. |
|
@jorgheymans sure sounds great. what would you like to name it? Like the file read idea. All sounds good! |
|
how about "java glyph tester" -> "a tool for testing the JDK font rendering behaviour" |
|
@jorgheymans great! here you go: |
Through this tool or an external tool? Is there a simple way to do this in Java? |
|
sure it's supposed to be only a couple of lines going through ImageIO , i will have a look at it. |
|
Sounds good. This will be a helpful tool. Thanks Jorg! |
|
@jorgheymans you should have write access on the Java Glyph Tester repository now. Let me know if you have any issues with it or if there is anything that I can do to help. cc: @texhex |
|
@jorgheymans Thanks for all the time and effort you put into this Jorg, I'm very sure this tool will help us a lot to get the Freescaler under control or at least prove that it's a Windows/Java issue and not an issue of the font. |
|
Access is working fine, just did initial commit. @texhex no worries 👍 |
|
@jorgheymans great! let us know what, if anything, we can do to help. |
|
To try to finalize this issue, are we in agreement about a workaround here? |
|
yes, i will send a PR this week sometime to the README explaining what is going on and how to workaround. (but it seems there is a PR pending not sure i have to wait for this one to be applied first). How about i put it in a README-intellij.md , catches the attention of those using the tool and others can just ignore it ? |
|
No rush on this. We can wait until the revisions on the README are complete. Just wondering what the approach will be. |
|
It looks as if this issue is fixed in latest intellij 2017.1 with jdk8_121, hurray ! |
|
Closing as fixed based upon comment in #129 (comment) |
When I put cursor to brackets, they get bold and the bottom line is not visible at all.
Windows, Hack-v2_015-ttf, size 12, changing line-spacing does not help.
The text was updated successfully, but these errors were encountered: