Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows 7, IntelliJ] the "g" character is sometimes not properly displayed #45

Closed
jorgheymans opened this issue Aug 31, 2015 · 24 comments

Comments

@jorgheymans
Copy link
Contributor

Hi,

I noticed that the "g" in below line of java code sometimes is not displayed properly, it looks like a "q". Behaviour seems to depend on where the caret is in the current file. Sometimes it shows fine sometimes not.

clipboard02

@jorgheymans
Copy link
Contributor Author

actually it happens with other characters ("j") as well, see below gif where i traverse a snippet of xml from top to bottom. Note when i move the caret back up the characters are restored line after line !

test

@chrissimpkins
Copy link
Member

bizarre. OK, likely a vertical spacing issue in this editor. will create a few spacing variations that we can try to see if they address it.

@chrissimpkins
Copy link
Member

I am combing the JetBrains issue reporting forums today. There are now several issues reported for the JetBrains editors that have not been reported for other editors (yet). Will add a new issue report if I can't come up with anything.

Updates to follow when I have them.

@jorgheymans
Copy link
Contributor Author

alright cool, let me know if you want me to test something !

@chrissimpkins chrissimpkins changed the title in intellij (windows 7), the "g" character is sometimes not properly displayed [Windows 7, IntelliJ] the "g" character is sometimes not properly displayed Sep 2, 2015
@Tiim
Copy link

Tiim commented Sep 3, 2015

I tried using build v2.011 like suggested in #77 but the issue remains unchanged.

intellij_hack_font

@chrissimpkins
Copy link
Member

Will you please give these new builds a try (v2.012)? I've updated the name tables and adjusted the font names based upon what is currently recommended for cross-platform support. Let's see if this addresses this issue.

Download Links
Regular
Bold
Italic
BoldItalic

@Tiim
Copy link

Tiim commented Sep 5, 2015

Unfortunately the issue is still persists.

@chrissimpkins
Copy link
Member

OK. I hoped this would be related to the name issue in these editors. Back to the drawing board...

@jorgheymans
Copy link
Contributor Author

Hi,

Tried the latest release, still same error but noticed that this only happens for font-size 12. As you can see in this gif i am changing the font size to 10-11-12-13-15 , only on 12 you can see these characters being clipped. Hoping this sheds some light on the problem !

only-size-12

@chrissimpkins
Copy link
Member

@heymjo Thanks for this info. Do you happen to know if this occurred at other text sizes in prior releases? I wouldn't expect any of the changes that were included in this release to influence this problem. Does it happen to go away at the 12px size when you adjust the line spacing setting to a larger (or smaller) value?

@jorgheymans
Copy link
Contributor Author

Changing the line spacing does not make a difference. Indeed, previous versions have exactly the same behaviour only at size 12.

@chrissimpkins
Copy link
Member

@heymjo thank you

@chrissimpkins
Copy link
Member

This is a priority and I intend to address it this weekend.  I know this is interfering with your use.  I have a few thoughts and will make some test builds that we can try.  


Chris

On Wed, Sep 9, 2015 at 4:22 AM, Jorg Heymans notifications@github.com
wrote:

Changing the line spacing does not make a difference. Indeed, previous versions have exactly the same behaviour only at size 12.

Reply to this email directly or view it on GitHub:
#45 (comment)

@jorgheymans
Copy link
Contributor Author

Great , thanks a lot !

@chrissimpkins
Copy link
Member

I'm hoping that the new test build (v2.014) addresses this issue. Vertical metrics have been updated. Please let me know how these files work.

They are available in #111

@jorgheymans
Copy link
Contributor Author

Fantastic, the issue has been resolved for me in this version 👍 . I am now going to use it as default font, many thanks and keep up the great work !

@chrissimpkins
Copy link
Member

Great to hear this! Any thoughts on the tighter spacing?

@jorgheymans
Copy link
Contributor Author

For me it still looks good, but then again i was not so picky about it in the first place :-)

@chrissimpkins
Copy link
Member

@heymjo That's great. Good to hear this. Waiting for a bit more input and will likely make this the default. We are planning some additional builds with looser spacing and can consider going even tighter if anyone wants this.

@jorgheymans
Copy link
Contributor Author

Reopening, unfortunately this behaviour has regressed from the .14 to the .15 release. Annoying because i did not keep the .14 release archive from #111 and it seems to have been removed :-|

@jorgheymans jorgheymans reopened this Oct 2, 2015
@chrissimpkins
Copy link
Member

I did a bit of repository cleanup. The test build is still there. Here is the link if you want it:

https://github.com/chrissimpkins/Hack/blob/development/build/test_builds/2_014/2_014.tar.gz?raw=true

Question is why this changed between the builds. To confirm, this is in IntelliJ IDEA on Windows?

@chrissimpkins
Copy link
Member

Do you mind checking issue #100 as well? This seems to be an associated issue and there is an active issue report on the JetBrains issue tracker about it:

https://youtrack.jetbrains.com/issue/IDEA-144785

@jorgheymans
Copy link
Contributor Author

Hi,

Strange things happening. It seems that when i first uninstall the font (going to the fonts directory and doing shift-delete), and only then install the new version it works fine.

What i did previously was just installing the new font on top of the old one and then the problems started to appear again. So i confirm that the latest version is working fine still 👍

@chrissimpkins
Copy link
Member

excellent! the cache is our enemy. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants