Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for using external redis #53

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Add examples for using external redis #53

merged 2 commits into from
Mar 2, 2022

Conversation

michaellzc
Copy link
Member

@michaellzc michaellzc commented Mar 1, 2022 •
edited
Loading

@michaellzc
Copy link
Member Author

michaellzc commented Mar 1, 2022 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@michaellzc michaellzc requested review from a team and mucles March 1, 2022 00:39
@michaellzc
Copy link
Member Author

@mucles maybe you can help take a look? I am hoping your CE experience can help judge if these examples make sense or not

@michaellzc michaellzc force-pushed the Add_examples_for_using_external_redis branch from 38055af to ce7d489 Compare March 1, 2022 01:50
@michaellzc michaellzc mentioned this pull request Mar 1, 2022
Draft
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch from 3929944 to bdddee6 Compare March 1, 2022 05:38
@michaellzc michaellzc force-pushed the Add_examples_for_using_external_redis branch from ce7d489 to 92fba7b Compare March 1, 2022 05:38
This was referenced Mar 1, 2022
Merged
Merged
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch from bdddee6 to 26210d7 Compare March 1, 2022 21:32
@michaellzc michaellzc force-pushed the Add_examples_for_using_external_redis branch 2 times, most recently from ffb5b19 to fe3478b Compare March 1, 2022 21:49
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch from 26210d7 to 1366f4b Compare March 1, 2022 21:55
@michaellzc michaellzc force-pushed the Add_examples_for_using_external_redis branch from fe3478b to 053d5e0 Compare March 1, 2022 21:55
@michaellzc michaellzc force-pushed the 02-25-Revamp_config_docs_with_helm-docs branch from 1366f4b to 09f629a Compare March 1, 2022 22:05
@michaellzc michaellzc force-pushed the Add_examples_for_using_external_redis branch from 053d5e0 to 8e9ed5c Compare March 1, 2022 22:05
caugustus-sourcegraph
caugustus-sourcegraph reviewed Mar 2, 2022
View reviewed changes
charts/sourcegraph/examples/external-redis/override-separate-configmap.yaml Outdated
@@ -0,0 +1,86 @@
# Demonstrate using external redis instance(s)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit of showing the exact same setup, with both a secret and a configmap? There's no significant difference between them, and it means more maintenance in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit of showing the exact same setup, with both a secret and a configmap? There's no significant difference between them, and it means more maintenance in the future.

🧐 I guess adding a reference k8s doc should be sufficient enough

still figuring out the right balance of how much k8s knowledge we should cover in docs/examples.

Base automatically changed from 02-25-Revamp_config_docs_with_helm-docs to main March 2, 2022 20:30
@michaellzc michaellzc force-pushed the Add_examples_for_using_external_redis branch from 9127663 to 89b4cac Compare March 2, 2022 20:35
@michaellzc michaellzc merged commit 8389421 into main Mar 2, 2022
@michaellzc michaellzc deleted the Add_examples_for_using_external_redis branch March 2, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugustus-sourcegraph caugustus-sourcegraph caugustus-sourcegraph approved these changes

@mucles mucles Awaiting requested review from mucles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm: add example values with external managed redis instances
2 participants
@michaellzc @caugustus-sourcegraph