Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration guide is nowhere near ready
Known Limitation
All
deploy
andsts
has to be recreated.In helm, we introduced two new labels to all
deploy
andsts
at.spec.selector.matchLabels
and.spec.template.metadata.labels
deploy-sourcegraph-helm/charts/sourcegraph/templates/frontend/sourcegraph-frontend.Deployment.yaml
Lines 18 to 21 in 9116a74
https://github.com/sourcegraph/deploy-sourcegraph/blob/f629296cddc1ec84cb31b95e7c874160d05b6bc5/base/frontend/sourcegraph-frontend.Deployment.yaml#L16-L18
Pod annotations are mutable but
deploy
's label selector is immutableUnable to use
kubeclt diff
to easily "diff" renderer manifest and cluster stateThe same deal. It just errored out and complained label selector is immutable.
helm template -n sourcegraph -f override.yaml sourcegraph charts/sourcegraph/ | kubectl diff -f -
Alternative
helm
to managed deployment lifecycle, instead they will just take the rendered manifest and plug back into their own pipeline.close https://github.com/sourcegraph/sourcegraph/issues/31967