Skip to content

Commit

Permalink
Fix build/CI and unused imports papercuts (#1974)
Browse files Browse the repository at this point in the history
- remove unused imports in `src/sourmash/search.py`
- add a `mypy` check task to `tox` (still need to be executed explicitly)
- set up dependabot for python, rust and gh action updates
  • Loading branch information
luizirber committed Apr 25, 2022
1 parent 7433b7f commit 0119cf7
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 7 deletions.
12 changes: 8 additions & 4 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,16 @@ updates:
- package-ecosystem: pip
directory: "/"
schedule:
interval: daily
time: "13:00"
interval: weekly
open-pull-requests-limit: 10
- package-ecosystem: cargo
directory: "/"
schedule:
interval: daily
time: "13:00"
interval: weekly
allow:
- dependency-type: "direct"
open-pull-requests-limit: 10
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: weekly
2 changes: 0 additions & 2 deletions src/sourmash/search.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"""
from collections import namedtuple
from enum import Enum
from multiprocessing.sharedctypes import Value
from re import I
import numpy as np
from dataclasses import dataclass

Expand Down
1 change: 0 additions & 1 deletion tests/test_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

# CTB TODO: test search protocol with mock class?

from pyparsing import original_text_for
import pytest
import sourmash_tst_utils as utils

Expand Down
9 changes: 9 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,15 @@ extras =
commands = pip wheel -w {envtmpdir}/build --no-deps .
twine check {envtmpdir}/build/*

[testenv:mypy]
description = run mypy checker
basepython = python3.8
passenv = {[testenv]passenv}
# without PROGRAMDATA cloning using git for Windows will fail with an `error setting certificate verify locations` error
PROGRAMDATA
deps = mypy
commands = mypy src/sourmash

[testenv:fix_lint]
description = format the code base to adhere to our styles, and complain about what we cannot do automatically
basepython = python3.8
Expand Down

0 comments on commit 0119cf7

Please sign in to comment.