Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build/CI and unused imports papercuts #1974

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

luizirber
Copy link
Member

  • remove unused imports in src/sourmash/search.py
  • add a mypy check task to tox (still need to be executed explicitly)
  • set up dependabot for python, rust and gh action updates

@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #1974 (9b94332) into latest (7433b7f) will increase coverage by 7.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #1974      +/-   ##
==========================================
+ Coverage   83.54%   91.43%   +7.89%     
==========================================
  Files         127       96      -31     
  Lines       14235     9953    -4282     
  Branches     1946     1946              
==========================================
- Hits        11892     9101    -2791     
+ Misses       2070      579    -1491     
  Partials      273      273              
Flag Coverage Δ
python 91.43% <ø> (-0.01%) ⬇️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/search.py 97.68% <ø> (-0.02%) ⬇️
src/core/src/ffi/utils.rs
src/core/src/ffi/index/mod.rs
src/core/src/ffi/mod.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/ffi/hyperloglog.rs
src/core/tests/minhash.rs
src/core/src/index/revindex.rs
src/core/src/index/linear.rs
src/core/src/index/sbt/mhbt.rs
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7433b7f...9b94332. Read the comment docs.

@luizirber luizirber requested a review from mr-eyes April 23, 2022 01:40
Copy link
Member

@mr-eyes mr-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! and I will just point the mypy update here to #1844 for future reference.

@mr-eyes
Copy link
Member

mr-eyes commented Apr 23, 2022

Seems like referencing is not working from the review comment so just mentioning again #1844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants