[WIP] Add windows and mac-arm64 wheels #1334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #1334 +/- ##
==========================================
- Coverage 81.04% 80.98% -0.07%
==========================================
Files 102 104 +2
Lines 10298 10312 +14
Branches 1165 1165
==========================================
+ Hits 8346 8351 +5
- Misses 1744 1753 +9
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
luizirber
force-pushed
the
windows_wheels
branch
3 times, most recently
from
dd7a917
to
cf55675
Compare
|
#1115 might fix the issue with windows builds |
luizirber
force-pushed
the
windows_wheels
branch
from
cf55675
to
4d050d4
Compare
|
I'll probably split this PR into two: one for windows wheels, another for |
1 task
luizirber
added a commit
that referenced
this pull request
Apr 8, 2022
Previous try (in #1334) tried to build `universal2` wheels on mac, but that's complicated. This PR builds two separated wheels, one for `arm64`, another for `x86_64`, and let `pip` choose the correct one during installation. I also updated `cibuildwheel` to list configuration in `pyproject.toml`, this way it can also be tested locally. (In preparation for fixing the currently broken `sourmash-minimal` package on `conda-forge`, which is not doing the cross-compilation properly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is built on top of #1564 now)
Checklist
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?