Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build macos arm64 wheels #1935

Merged
merged 1 commit into from
Apr 8, 2022
Merged

build macos arm64 wheels #1935

merged 1 commit into from
Apr 8, 2022

Conversation

luizirber
Copy link
Member

Previous try (in #1334) tried to build universal2 wheels on mac, but that's complicated. This PR builds two separated wheels, one for arm64, another for x86_64, and let pip choose the correct one during installation.

I also updated cibuildwheel to list configuration in pyproject.toml, this way it can also be tested locally.

(In preparation for fixing the currently broken sourmash-minimal package on conda-forge, which is not doing the cross-compilation properly).

@luizirber luizirber requested review from ctb and a team and removed request for ctb April 8, 2022 00:00
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1935 (bd23914) into latest (a998a6a) will increase coverage by 8.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #1935      +/-   ##
==========================================
+ Coverage   82.93%   90.96%   +8.03%     
==========================================
  Files         125       94      -31     
  Lines       13755     9479    -4276     
  Branches     1877     1877              
==========================================
- Hits        11408     8623    -2785     
+ Misses       2075      584    -1491     
  Partials      272      272              
Flag Coverage Δ
python 90.96% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/ffi/storage.rs
src/core/src/signature.rs
src/core/tests/test.rs
src/core/src/ffi/minhash.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/index/search.rs
src/core/src/cmd.rs
src/core/src/ffi/nodegraph.rs
src/core/src/index/revindex.rs
src/core/src/ffi/signature.rs
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a998a6a...bd23914. Read the comment docs.

@luizirber luizirber enabled auto-merge (squash) April 8, 2022 14:37
@luizirber luizirber merged commit 93cbd3a into latest Apr 8, 2022
@luizirber luizirber deleted the lirber/macos_crossbuild branch April 8, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants