[MRG] update release procedure after v4.6.0 and v4.6.1 #2386

ctb · 2022-12-02T14:32:23Z

This PR:

adjusts tag commands to avoid wheels getting uploaded to the github release candidate;
switches make test for pytest && cargo test
eliminates the pypi test server section because of this issue, which has been a longstanding problem with our releases
explicit installs wheel wherever possible
does a pip install -U in the release/build conda environment
makes rustup update an explicit part of the release docs
updates release note guide with dependabot category
fixes release tag command to use -m so that we don't have to open up an editor.

codecov · 2022-12-02T14:40:22Z

Codecov Report

Merging #2386 (001235b) into latest (7f9ca67) will increase coverage by 7.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2386      +/-   ##
==========================================
+ Coverage   84.72%   92.52%   +7.80%     
==========================================
  Files         132      103      -29     
  Lines       14731    11937    -2794     
  Branches     2503     2503              
==========================================
- Hits        12481    11045    -1436     
+ Misses       1948      590    -1358     
  Partials      302      302

Flag	Coverage Δ
python	`92.52% <ø> (ø)`
rust	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/core/src/index/mod.rs
src/core/src/ffi/minhash.rs
src/core/src/lib.rs
src/core/src/ffi/utils.rs
src/core/src/sketch/nodegraph.rs
src/core/tests/minhash.rs
src/core/src/ffi/index/mod.rs
src/core/src/from.rs
src/core/src/index/revindex.rs
src/core/src/ffi/signature.rs
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ctb · 2022-12-02T15:20:34Z

Ready for review - would appreciate @luizirber taking a look. No urgency.

luizirber · 2023-02-12T07:02:51Z

doc/release.md

 3\. Test the release candidate. Bonus: repeat on macOS:
 ```
 python -m pip install -U pip
-python -m pip install -U virtualenv wheel tox-setuptools-version build


don't need any of these

luizirber · 2023-02-12T07:03:06Z

doc/release.md

@@ -123,7 +135,6 @@ python -m venv testenv4

 cd testenv1
 source bin/activate
-python -m pip install wheel


no need for wheel here

luizirber · 2023-02-12T07:04:02Z

doc/release.md

@@ -147,7 +158,6 @@ cp dist/sourmash*tar.gz ../../../testenv3/
 cd ../../../testenv3/
 deactivate
 source bin/activate
-python -m pip install pytest build wheel


pip install -r requirements.txt below will install pytest, and we don't need the others

ctb · 2023-02-17T15:07:58Z

Any concerns with me updating & merging this @luizirber , once #2432 is merged?

luizirber · 2023-02-18T05:50:19Z

Any concerns with me updating & merging this @luizirber , once #2432 is merged?

Nope, go for it! I set #2432 for merging when checks pass

Closes #2431 Relevant to #2425 because it removes `setuptools_scm` from docs. Also brings in the `pyproject.toml` changes needed for #2386

…o update/release_460

Minor fixes after #2386 - * be more specific about what to look for on RTD; * package `CITATION.cff` in source distributions so that `test_citation_file` works.

# sourmash release 4.7.0 Major new features: * provide an initial plugin architecture for sourmash that supports new signature saving & loading mechanisms (#2428) * add plugin support for new command-line subcommands (#2438) * debias all containment values (#2243) Minor new features: * Use RankLineageInfo to simplify reading lineages (#2467) * store taxids in lineageDB (#2466) * Use new tax classes for taxonomic summarization (#2443) * add tax summarization dataclasses for safety and flexibility (#2439) * add `--scaled` to sourmash compare (#2414) * replace `lca_utils.LineagePair` with `tax_utils.LineagePair` (#2441) * Add new classes for lineage manipulation (#2437) Cleanup and documentation updates: * ReadTheDocs updates (#2445) * update `sourmash compare` command-line docs (#2400) Developer updates: * fix python tests by bumping tox and pip cache versions (#2424) * Update sphinx requirement from <6,>=4.4.0 to >=4.4.0,<7 (#2430) * Build: replace milksnake with maturin (#2393) * importlib_metadata is a dependency on old Python versions (#2484) * Release docs: use two separate sed commands (#2483) * minor fixes to release behavior (#2479) * Use screed and maturin from nixpkgs in `flake.nix` (#2481) * update release procedure after v4.6.0 and v4.6.1 (#2386) * Update makefile and docs (#2432) Dependabot updates: * Bump once_cell from 1.17.0 to 1.17.1 (#2488) * Bump ouroboros from 0.15.5 to 0.15.6 (#2487) * Bump memmap2 from 0.5.8 to 0.5.9 (#2486) * Bump supercharge/redis-github-action from 1.4.0 to 1.5.0 (#2485) * Bump proptest from 1.0.0 to 1.1.0 (#2460) * Bump web-sys from 0.3.60 to 0.3.61 (#2461) * Bump serde_json from 1.0.91 to 1.0.93 (#2471) * Bump wasm-bindgen-test from 0.3.33 to 0.3.34 (#2463) * Bump cachix/install-nix-action from 18 to 19 (#2459) * Bump wasm-bindgen from 0.2.83 to 0.2.84 (#2464) * Bump typed-builder from 0.11.0 to 0.12.0 (#2451) * Bump bumpalo from 3.9.1 to 3.12.0 (#2450) * Bump pypa/cibuildwheel from 2.11.4 to 2.12.0 (#2447) * Bump bzip2 from 0.4.3 to 0.4.4 (#2444) * Bump once_cell from 1.14.0 to 1.17.0 (#2429) * Bump serde from 1.0.151 to 1.0.152 (#2423) * Bump pypa/cibuildwheel from 2.11.3 to 2.11.4 (#2422) * Bump serde_json from 1.0.89 to 1.0.91 (#2418) * Bump serde from 1.0.150 to 1.0.151 (#2419) * Bump thiserror from 1.0.37 to 1.0.38 (#2417) * Bump finch from 0.4.3 to 0.5.0 (#2416) * Bump rayon from 1.6.0 to 1.6.1 (#2404) * Bump serde from 1.0.149 to 1.0.150 (#2403) * Bump pypa/cibuildwheel from 2.11.2 to 2.11.3 (#2402) * Bump serde from 1.0.148 to 1.0.149 (#2397) * Bump capnp from 0.14.5 to 0.14.11 (#2396)

Minor updates after releasing v4.7.0, following the maturin-inspired changes in #2386, #2481, and #2479. * fix chdir command * use PR rather than issue for release notes * update zenodo URL for checking zenodo DOI minting

ctb marked this pull request as ready for review December 2, 2022 15:20

ctb changed the title ~~[WIP] update release procedure for v4.6.0~~ [MRG] update release procedure for v4.6.0 Dec 2, 2022

ctb mentioned this pull request Dec 3, 2022

[MRG] fix sourmash sketch ... -o <file>.zip bug introduced in #2329 and released in v4.6.0 #2391

Merged

ctb changed the title ~~[MRG] update release procedure for v4.6.0~~ [MRG] update release procedure after v4.6.0 and v4.6.1 Dec 3, 2022

ctb mentioned this pull request Dec 27, 2022

Replace milksnake with maturin #2393

Merged

4 tasks

luizirber mentioned this pull request Dec 28, 2022

Automated versioning for releases #2425

Open

luizirber force-pushed the update/release_460 branch 2 times, most recently from 7d6d779 to e620ef4 Compare February 12, 2023 06:54

luizirber reviewed Feb 12, 2023

View reviewed changes

luizirber mentioned this pull request Feb 12, 2023

Update makefile and docs #2432

Merged

luizirber force-pushed the update/release_460 branch from e620ef4 to 393cba3 Compare February 12, 2023 23:35

ctb and others added 8 commits February 13, 2023 19:21

update release procedure for v4.6.0

5b46440

more changes

56b5b6a

update categories for release notes

cc47cae

shift draft release notes section

34e7766

fix tag to use -m

41c415c

upd with checklist

d86db4c

maturin build updates

a445a5c

also update version in flake.nix

c917072

luizirber force-pushed the update/release_460 branch from 393cba3 to c917072 Compare February 14, 2023 03:22

luizirber self-requested a review February 18, 2023 05:50

luizirber approved these changes Feb 18, 2023

View reviewed changes

luizirber added a commit that referenced this pull request Feb 18, 2023

Update makefile and docs (#2432)

7f9ca67

Closes #2431 Relevant to #2425 because it removes `setuptools_scm` from docs. Also brings in the `pyproject.toml` changes needed for #2386

Merge branch 'latest' of https://github.com/sourmash-bio/sourmash int…

001235b

…o update/release_460

ctb enabled auto-merge (squash) February 18, 2023 14:22

ctb merged commit da6af53 into latest Feb 18, 2023

ctb deleted the update/release_460 branch February 18, 2023 14:37

ctb mentioned this pull request Feb 19, 2023

[MRG] minor fixes to release behavior #2479

Merged

ctb added a commit that referenced this pull request Feb 20, 2023

[MRG] minor fixes to release behavior (#2479)

b08ac03

Minor fixes after #2386 - * be more specific about what to look for on RTD; * package `CITATION.cff` in source distributions so that `test_citation_file` works.

ctb mentioned this pull request Mar 3, 2023

4.7.0 release #2497

Merged

This was referenced Mar 3, 2023

MRG: minor fixes to release docs after v4.7.0 #2498

Merged

re-add LICENSE file into source dist #2504

Closed

ctb mentioned this pull request Mar 8, 2023

setting version numbers for in-development versions #2517

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MRG] update release procedure after v4.6.0 and v4.6.1 #2386

[MRG] update release procedure after v4.6.0 and v4.6.1 #2386

ctb commented Dec 2, 2022 •

edited

Loading

codecov bot commented Dec 2, 2022 •

edited

Loading

ctb commented Dec 2, 2022

luizirber Feb 12, 2023

luizirber Feb 12, 2023

luizirber Feb 12, 2023

ctb commented Feb 17, 2023

luizirber commented Feb 18, 2023

[MRG] update release procedure after v4.6.0 and v4.6.1 #2386

[MRG] update release procedure after v4.6.0 and v4.6.1 #2386

Conversation

ctb commented Dec 2, 2022 • edited Loading

codecov bot commented Dec 2, 2022 • edited Loading

Codecov Report

ctb commented Dec 2, 2022

luizirber Feb 12, 2023

Choose a reason for hiding this comment

luizirber Feb 12, 2023

Choose a reason for hiding this comment

luizirber Feb 12, 2023

Choose a reason for hiding this comment

ctb commented Feb 17, 2023

luizirber commented Feb 18, 2023

ctb commented Dec 2, 2022 •

edited

Loading

codecov bot commented Dec 2, 2022 •

edited

Loading