Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump once_cell from 1.14.0 to 1.17.0 #2429

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 2, 2023

Bumps once_cell from 1.14.0 to 1.17.0.

Changelog

Sourced from once_cell's changelog.

1.17.0

  • Add race::OnceRef for storing a &'a T.

1.16.0

  • Add no_std implementation based on critical-section, #195.
  • Deprecate atomic-polyfill feature (use the new critical-section instead)

1.15.0

  • Increase minimal supported Rust version to 1.56.0.
  • Implement UnwindSafe even if the std feature is disabled.
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @luizirber.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust labels Jan 2, 2023
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #2429 (8a6a588) into latest (059d988) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           latest    #2429   +/-   ##
=======================================
  Coverage   84.08%   84.08%           
=======================================
  Files         130      130           
  Lines       15044    15044           
  Branches     2403     2403           
=======================================
  Hits        12650    12650           
  Misses       2098     2098           
  Partials      296      296           
Flag Coverage Δ
python 92.22% <ø> (ø)
rust 57.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb
Copy link
Contributor

ctb commented Jan 3, 2023

@dependabot rebase

Bumps [once_cell](https://github.com/matklad/once_cell) from 1.14.0 to 1.17.0.
- [Release notes](https://github.com/matklad/once_cell/releases)
- [Changelog](https://github.com/matklad/once_cell/blob/master/CHANGELOG.md)
- [Commits](matklad/once_cell@v1.14.0...v1.17.0)

---
updated-dependencies:
- dependency-name: once_cell
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/once_cell-1.17.0 branch from 7dda839 to 84994b8 Compare January 3, 2023 15:36
@ctb
Copy link
Contributor

ctb commented Jan 3, 2023

@luizirber the dev env instructions/nix actions are failing with:

building '/nix/store/30s0w82n9dikl3rcyz1gq3zdvy3962lp-sourmash-4.6.1-vendor.tar.gz.drv'...
error: hash mismatch in fixed-output derivation '/nix/store/30s0w82n9dikl3rcyz1gq3zdvy3962lp-sourmash-4.6.1-vendor.tar.gz.drv':
         specified: sha256-IaIX4RdXEhLQhne+QiSfdP1KiIwZUqxRg14uWknS+0o=
            got:    sha256-gcjqPgLhqNUKCu4MF9QnUi/m/kknbGQXU+gCi96vRxg=
error: 1 dependencies of derivation '/nix/store/xigfh2n0p8hxx1rkcbpr0r0wjza67ay8-python3.10-sourmash-4.6.1.drv' failed to build

(see e.g.https://github.com/sourmash-bio/sourmash/actions/runs/3824865702/jobs/6508185438)

No idea what this means 😆

@luizirber
Copy link
Member

@luizirber the dev env instructions/nix actions are failing

Fixed in 8a6a588

The issue is that rustPlatform.fetchCargoTarball has a fixed sha256 that will obviously be different on every dependabot update. For dev purposes replacing with rustPlatform.importCargoLock (which still calculates a sha256, but based on the Cargo.lock file), which supports the dependabot PRs use case.

@luizirber
Copy link
Member

@dependabot squash and merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 4, 2023

Dependabot tried to merge this PR, but received the following error from GitHub:

At least 1 approving review is required by reviewers with write access.

@ctb
Copy link
Contributor

ctb commented Jan 4, 2023

@luizirber the dev env instructions/nix actions are failing

Fixed in 8a6a588

The issue is that rustPlatform.fetchCargoTarball has a fixed sha256 that will obviously be different on every dependabot update. For dev purposes replacing with rustPlatform.importCargoLock (which still calculates a sha256, but based on the Cargo.lock file), which supports the dependabot PRs use case.

OK, thanks!

Wouldn't this happen with every dependabot update then? This is the first time I've seen it...

@ctb ctb merged commit 079a2ba into latest Jan 4, 2023
@ctb ctb deleted the dependabot/cargo/once_cell-1.17.0 branch January 4, 2023 13:20
@ctb ctb mentioned this pull request Mar 3, 2023
ctb added a commit that referenced this pull request Mar 3, 2023
# sourmash release 4.7.0

Major new features:

* provide an initial plugin architecture for sourmash that supports new
signature saving & loading mechanisms (#2428)
* add plugin support for new command-line subcommands (#2438)
* debias all containment values (#2243)

Minor new features:

* Use RankLineageInfo to simplify reading lineages (#2467)
* store taxids in lineageDB (#2466)
* Use new tax classes for taxonomic summarization (#2443)
* add tax summarization dataclasses for safety and flexibility (#2439)
* add `--scaled` to sourmash compare (#2414)
* replace `lca_utils.LineagePair` with `tax_utils.LineagePair` (#2441)
* Add new classes for lineage manipulation (#2437)

Cleanup and documentation updates:

* ReadTheDocs updates (#2445)
* update `sourmash compare` command-line docs (#2400)

Developer updates:

* fix python tests by bumping tox and pip cache versions (#2424)
* Update sphinx requirement from <6,>=4.4.0 to >=4.4.0,<7 (#2430)
* Build: replace milksnake with maturin (#2393)
* importlib_metadata is a dependency on old Python versions (#2484)
* Release docs: use two separate sed commands (#2483)
* minor fixes to release behavior (#2479)
* Use screed and maturin from nixpkgs in `flake.nix` (#2481)
* update release procedure after v4.6.0 and v4.6.1 (#2386)
* Update makefile and docs (#2432)

Dependabot updates:

* Bump once_cell from 1.17.0 to 1.17.1 (#2488)
* Bump ouroboros from 0.15.5 to 0.15.6 (#2487)
* Bump memmap2 from 0.5.8 to 0.5.9 (#2486)
* Bump supercharge/redis-github-action from 1.4.0 to 1.5.0 (#2485)
* Bump proptest from 1.0.0 to 1.1.0 (#2460)
* Bump web-sys from 0.3.60 to 0.3.61 (#2461)
* Bump serde_json from 1.0.91 to 1.0.93 (#2471)
* Bump wasm-bindgen-test from 0.3.33 to 0.3.34 (#2463)
* Bump cachix/install-nix-action from 18 to 19 (#2459)
* Bump wasm-bindgen from 0.2.83 to 0.2.84 (#2464)
* Bump typed-builder from 0.11.0 to 0.12.0 (#2451)
* Bump bumpalo from 3.9.1 to 3.12.0 (#2450)
* Bump pypa/cibuildwheel from 2.11.4 to 2.12.0 (#2447)
* Bump bzip2 from 0.4.3 to 0.4.4 (#2444)
* Bump once_cell from 1.14.0 to 1.17.0 (#2429)
* Bump serde from 1.0.151 to 1.0.152 (#2423)
* Bump pypa/cibuildwheel from 2.11.3 to 2.11.4 (#2422)
* Bump serde_json from 1.0.89 to 1.0.91 (#2418)
* Bump serde from 1.0.150 to 1.0.151 (#2419)
* Bump thiserror from 1.0.37 to 1.0.38 (#2417)
* Bump finch from 0.4.3 to 0.5.0 (#2416)
* Bump rayon from 1.6.0 to 1.6.1 (#2404)
* Bump serde from 1.0.149 to 1.0.150 (#2403)
* Bump pypa/cibuildwheel from 2.11.2 to 2.11.3 (#2402)
* Bump serde from 1.0.148 to 1.0.149 (#2397)
* Bump capnp from 0.14.5 to 0.14.11 (#2396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants