Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: output bioboxes profile from tax metagenome (for CAMI) #2468

Merged
merged 87 commits into from
Apr 5, 2023

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Feb 9, 2023

Write bioboxes profiling format from tax metagenome, which can be used for CAMI submissions and comparisons.
The file produced by this output must have a .profile extension.

rendered sourmash bioboxes output format documentation

References:

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #2468 (ce4b8c4) into latest (827b897) will increase coverage by 0.04%.
The diff coverage is 98.21%.

@@            Coverage Diff             @@
##           latest    #2468      +/-   ##
==========================================
+ Coverage   92.64%   92.69%   +0.04%     
==========================================
  Files         104      104              
  Lines       12267    12321      +54     
  Branches     2279     2598     +319     
==========================================
+ Hits        11365    11421      +56     
+ Misses        599      598       -1     
+ Partials      303      302       -1     
Flag Coverage Δ
python 92.69% <98.21%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/cli/utils.py 97.75% <75.00%> (-1.09%) ⬇️
src/sourmash/cli/tax/metagenome.py 100.00% <100.00%> (ø)
src/sourmash/tax/__main__.py 94.19% <100.00%> (+0.10%) ⬆️
src/sourmash/tax/tax_utils.py 98.34% <100.00%> (+0.05%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luizirber
Copy link
Member

(I think this will close #1606 too?)

Base automatically changed from alt-lindb to latest February 13, 2023 16:01
@bluegenes bluegenes changed the base branch from latest to lins-v2 March 8, 2023 21:09
@bluegenes
Copy link
Contributor Author

@luizirber is there a reason you used Version:0.10.0 as compared with the 0.9.3 on https://github.com/bioboxes/rfc/blob/60263f34c57bc4137deeceec4c68a7f9f810f6a5/data-format/profiling.mkd?

@bluegenes bluegenes marked this pull request as ready for review March 8, 2023 23:14
@bluegenes bluegenes changed the title WIP: write CAMI output from tax metagenome MRG: write bioboxes profile output from tax metagenome (for CAMI) Mar 8, 2023
@bluegenes bluegenes changed the title MRG: write bioboxes profile output from tax metagenome (for CAMI) MRG: output bioboxes profile from tax metagenome (for CAMI) Mar 8, 2023
@bluegenes
Copy link
Contributor Author

@sourmash-bio/devs ready for review!

This PR is into #2469 for convenience /avoiding conflicts, but we should keep it separate and merge into latest after #2469 has been merged (that PR is huge and the functionality is distinct).

Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice!

doc/command-line.md Outdated Show resolved Hide resolved
Co-authored-by: C. Titus Brown <titus@idyll.org>
@luizirber
Copy link
Member

luizirber commented Mar 9, 2023

@luizirber is there a reason you used Version:0.10.0 as compared with the 0.9.3 on https://github.com/bioboxes/rfc/blob/60263f34c57bc4137deeceec4c68a7f9f810f6a5/data-format/profiling.mkd?

I don't remember... Probably because I was following the newest version I could find, but seems no tool ever implemented it...

PR describing the changes from 0.9 to 0.10: bioboxes/rfc#216

@bluegenes
Copy link
Contributor Author

@dkoslicki does this fit requirements for CAMI intake?

@dkoslicki
Copy link
Collaborator

@dkoslicki does this fit requirements for CAMI intake?

Yes, that it does! It will make OPAL comparisons and the like much easier!

Base automatically changed from lins-v2 to latest April 5, 2023 14:00
@bluegenes bluegenes merged commit fd53c50 into latest Apr 5, 2023
@bluegenes bluegenes deleted the add-cami-output branch April 5, 2023 15:30
@ctb ctb mentioned this pull request Apr 6, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants