MRG: update prefetch/gather output to be clearer #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #2543 +/- ##
==========================================
+ Coverage 85.18% 92.82% +7.63%
==========================================
Files 133 104 -29
Lines 15163 12380 -2783
Branches 2608 2610 +2
==========================================
- Hits 12917 11492 -1425
+ Misses 1945 587 -1358
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…o update/prefetch_gather_comms
|
Ready for review @sourmash-bio/devs - will need to update to latest, and also running afoul of #2544 in the tests. |
…o update/prefetch_gather_comms
…o update/prefetch_gather_comms
bluegenes
reviewed
Apr 5, 2023
| @@ -797,7 +797,8 @@ def gather(args): | |||
| if prefetch_csvout_fp: | |||
| prefetch_csvout_fp.flush() | |||
|
|
|||
| notify(f"Found {len(save_prefetch)} signatures via prefetch; now doing gather.") | |||
| display_bp = format_bp(args.threshold_bp) | |||
| notify(f"Prefetch found {len(save_prefetch)} signatures with overlap >= {display_bp}.") | |||
There was a problem hiding this comment.
should we notify anything about #2318?
There was a problem hiding this comment.
I think linking this PR into that issue is enough? :) yeah that requires a whole different set of foo!
…o update/prefetch_gather_comms
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2539
This PR:
No matches found for --threshold-bp at ...