Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] PyPI fixes #504

Merged
merged 3 commits into from
Jun 25, 2018
Merged

[MRG] PyPI fixes #504

merged 3 commits into from
Jun 25, 2018

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Jun 22, 2018

It's been some time since we uploaded releases to PyPI, and things changed:

  • Warehouse was deployed, so it supports Markdown in the long_description field. I decided to put the README.md file there (which makes GitHub and PyPI look the same)
  • Markdown support requires setuptools>=38.6.0, which is a fairly recent version. I bumped the version in setup.py, so this would probably also fix what version of setuptools do we require? #173
  • Update README to point to pre-releases instead of installing from master
  • Update DBs in docs (for 2.0.0a8)

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Jun 22, 2018

Codecov Report

Merging #504 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files          33       33           
  Lines        4999     4999           
  Branches       36       36           
=======================================
  Hits         4534     4534           
  Misses        464      464           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016e17e...d6caf0c. Read the comment docs.

@luizirber luizirber changed the title [WIP] PyPI fixes [MRG] PyPI fixes Jun 22, 2018
@luizirber
Copy link
Member Author

Example of rendered description:
https://test.pypi.org/project/sourmash/2.0.0a8/

@luizirber
Copy link
Member Author

ready for review @ctb @taylorreiter @brooksph @bluegenes

@luizirber luizirber merged commit cf20a94 into master Jun 25, 2018
@luizirber luizirber deleted the fix/pypi_description branch June 25, 2018 21:15
luizirber added a commit that referenced this pull request Jul 23, 2018
- avoid calling node.data (#516)
  This makes `sourmash gather` ~40% faster...
- make sourmash compatible with khmer 3 (#508)
  Even tho khmer 3 it's not released, there is an alpha version on bioconda
- manylinux1 wheels and travis build improvements (#507)
- PyPI fixes (#504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

what version of setuptools do we require?
3 participants