[MRG] manylinux1 wheels and travis build improvements #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 90.69% 90.78% +0.08%
==========================================
Files 33 33
Lines 4999 5003 +4
Branches 36 36
==========================================
+ Hits 4534 4542 +8
+ Misses 464 461 -3
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
ctb
reviewed
Jun 25, 2018
| deploy: | ||
| provider: releases | ||
| api_key: | ||
| secure: CTO7kiWKLper/nJU093pp796P6MhV2IPz4M2Ws0//YOqU2gKZalyGmAdJtqsFk0+eZthnOp0GQzuSJYpN0+jOx3IU+SInnMg7HdLooyfLxgjDri9xOMBtTiCzSbY77NnLKNk4Nj8idb3Gfjp0F+/5TIRlpInTZ7iYGoG1ZYM/kCyBiTkzDd8tO1LBKhWBad3h3bv099OcmoYT7GETuS9LMmUYJLOe/aotOfOhSttNxYIIIY2RmjFQjWBZCAWPx9P8PnTdhDmrMQL9kRBz+z9/E+ikaaMgtx9QTsF75mZn1qix0+a0LwvRaXKCzYCZ7KGUaSs/npIrBbtXxxA7wK4GFTGb2ERpJOzp4MGzwLiToQlNOHZ48F2N3RgQVL0v+rfvGjt14csWRA21jfrvP2yk4G8lrHZsVxdBeMyPw8/4EnFm307zZbd8LY21byz2K9450mzExLGTx+0AWKQGyygT6PPOXYsNqxC5XEMNZDKTknaGQ1RjiZwRnZAq9quk4KNNmfbgRnuEVKcK0SXeudq3wRwbyA5jT/cYaScfBAdhAgge6tto9aEss+mUEEhm1ZmCxSAfTRKJgE3+ug4npTSSb0KLdGWW4V+ygQ2t+kA9G+1j7U01CGG3jY7aPc/mnJF7Sb2XP0+PNS9eLZpXa6rlJ/1ieMSqppuvvgQgHmKHVs= |
There was a problem hiding this comment.
are you sure you want this checked in?
There was a problem hiding this comment.
|
(for those curious: this is how many tries it took to figure out this PR |
luizirber
changed the title
|
Ready for review and merge @ctb |
ctb
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures Travis to build wheels for manylinux1 (the catch-all version for compatible binary Python wheels). Wheel building is executed only on tags, and for now it is deploying to GitHub Releases (we want to deploy it to PyPI too)
I'm using an OAuth token linked to my account to upload the wheels to GitHub, so we might want to figure out another approach (maybe make a
diblab-releaseaccount, and add it to PyPI/bio.tools and other services too?)Bonus: since I generated the khmer wheels for this, I also uploaded them to PyPI and now the Travis jobs run way faster (because we don't need to recompile khmer every time...)
Not covered here:
checklist
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?