-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] use tox for running tests locally #696
Conversation
c8160be
to
015bf25
Compare
015bf25
to
e8f7afa
Compare
Codecov Report
@@ Coverage Diff @@
## latest #696 +/- ##
===========================================
+ Coverage 83.32% 93.95% +10.63%
===========================================
Files 103 98 -5
Lines 9600 14615 +5015
Branches 0 1434 +1434
===========================================
+ Hits 7999 13732 +5733
+ Misses 1601 637 -964
- Partials 0 246 +246
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b5aefe5
to
8be429d
Compare
a47cd64
to
1eb8804
Compare
1e2a83c
to
7707359
Compare
This branch runs |
6f1c084
to
b68ab80
Compare
b68ab80
to
154bf2f
Compare
d3510e4
to
c1ec864
Compare
move most of setup.py to pyproject.toml and setup.cfg use isolated build for package creation isolate test running add some pyscaffold-inspired changes update precommit isort config tox.ini updates based on tox-dev/tox fix benchmarks for CI, add pypy wheels add nix.shell for env setup move sourmash to src/sourmash coverage fixes
d8cd27d
to
10ead56
Compare
10ead56
to
74a5bd9
Compare
reviewing tox part of thingsI started out by creating a new conda environment with python3.8 in it, and running tox; got:
(I think the py38 / InvocationError is just a network error, so that's ok; will try again later.) I'm not a fan of having the default be that a user has to have python 3.7, 3.8, and 3.9 installed just to run basic tests, so I suggest making that clear; I'll revisit the docs with that in mind.
|
as far as moving code under |
(as far as breaking existing PRs... most of them are yours!) |
Hmm, what version of tox are you running? I set up (is this running on this branch? or
It makes sense that running This worked for me:
(I used
Hmm, I'm increasingly thinking that you're not in the |
On Thu, Dec 10, 2020 at 09:23:13AM -0800, Luiz Irber wrote:
(is this running on this branch? or `latest`? Because `docs` should always be using 3.8, and I see it trying to use 3.7 :thinking:)
oh. sorry. I think you nailed it :). trying again!
|
I get that, and it is a big change, but there are good reasons to use the
Good, so it is up to me to fix them =] |
6465359
to
27ed5be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, nice work!
I think it would be good to update the docs to point at src/sourmash/
rather than sourmash/
.
Also, is there any documentation for the nix
stuff?
Yup, I'll do that now.
I'll add docs and CI for that, it's what I've been using for local dev in my laptop (setting up Rust, python and tox), but since I do most of my dev in the remote workstation it is not as well tested/organized yet. |
On Tue, Dec 15, 2020 at 10:42:31AM -0800, Luiz Irber wrote:
> Also, is there any documentation for the `nix` stuff?
I'll add docs and CI for that, it's what I've been using for local dev in my laptop (setting up Rust, python and tox), but since I do most of my dev in the remote workstation it is not as well tested/organized yet.
ok, no worries/no need to invest in that now, but might be good to have an
issue placeholder for this.
|
Benefits:
tox
, and it takes care of installing all other deps.(This is a slim version of #680, skipping the
fix_lint
parts that change A LOT of code)Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?changes were made?