Indexing in Rust #773
Merged
Indexing in Rust #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relevant before merging: doesn't change anything in the Python parts. |
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
=========================================
- Coverage 89.6% 50% -39.61%
=========================================
Files 30 13 -17
Lines 4706 1828 -2878
Branches 49 450 +401
=========================================
- Hits 4217 914 -3303
- Misses 485 615 +130
- Partials 4 299 +295
Continue to review full report at Codecov.
|
luizirber
force-pushed
the
rust/index_abc
branch
6 times, most recently
from
b51846c
to
bb6ab88
Compare
|
(side benefits: with coverage being tracked now I actually have to write tests to bring the Rust coverage up 🤣) |
luizirber
force-pushed
the
rust/index_abc
branch
from
bb6ab88
to
6a21e96
Compare
luizirber
force-pushed
the
rust/index_abc
branch
5 times, most recently
from
847da8d
to
577517a
Compare
luizirber
force-pushed
the
rust/index_abc
branch
12 times, most recently
from
2ef0132
to
20cdd7b
Compare
luizirber
force-pushed
the
rust/index_abc
branch
from
eb2461e
to
40d4616
Compare
add coverage CI job initial index cmd impl add batch_insert method use needletail for fastx parsing fix finch feature lint clippy fix benchmarks update CI comment out code that depends on unreleased crates... another ci check, can we publish it\? add windows, macos, beta and nightly tests tests move ocf to another repo needletail 0.3.2 update for finch 0.3.0 fix warnings initial search test oracle test oracle tests for search install sourmash for oracle tests use better_panic better_panic does not work on wasm32 yet.. bring in changes from core/rust update sourmash.h fix keep nodegraph working on wasm32 upgrades hash_functions use only hash_functions internally update sourmash.h from and clippy bring back oracle tests test improvements niffler instead of ocf test all features for coverage use released niffler indexing almost there compatibility with sourmash-py SBT note about md5sum and filenames move tests into specific SBTs remove unwrap
luizirber
force-pushed
the
rust/index_abc
branch
from
40d4616
to
c992f28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust parts could read a SBT and search it, but proper indexing was not implemented. Working on it now.
Other changes:
Checklist
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?